WIP Control Flow v2 #280
Merged
WIP Control Flow v2 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 27, 2018 10:18
…syntax validation) and process (generating the linked list) test groups. Processing is still WIP.
dependency between Command and CommandStackHandler.
…n after storing them. Updated tests to use the return value instead of relying on the variable name since the implementation could change.
…eprocessStack into stack and work with just stack.
…preprocess for each Command.
…et of mutation functions (names TBD) called from within CommandStackHandler. Also swapped out Object.assign for the spread operator when creating array copies.
…which is for public vs. internal use.
… file/directory structure outside of __test__
… commands itself. Also refactored checks against the command name into functions, and renamed the mutation methods into something more descriptive.
…Moved it to the root of the IO directory, updated tests accordingly, and removed unnecessary files and folders. Also added additional isCommandType style functions and refactored all command type checks to use them.
…es a push down automata and finished implementing the currently written test cases.
…ct command references and removed this check from the other command node tests. Also added test coverage and implementation for some additional cases.
…e to use the correct getter (e.g., command instead of name)
…into its own file
added 8 commits
July 31, 2018 14:56
…ds) and added a generic 'verify' command to accompany the 'assert' command added yesterday.
…andNode#execute`.
…nstead of by name). Updated the serialize command tests for control flow to use ControlFlowCommandNames. Cleaned up control flow commands in models/Command by removing type and fixed the word wrap on some error text in playback (to be consistent with what's done in other files).
added 16 commits
August 1, 2018 12:53
…un would hang (and couldn't abort gracefully) when a variable name wasn't provided
…s the last one (assumes usage outside of control flow commands).
…ecute script test and move the remaining one into the smoke suite.
… passes the result object back, with the next node included.
… a simple object. Kept `startingCommandNode` and removed `currentCommandNode` since this differentiation is no longer needed. Updated its usage accordingly.
…eleniumCommand` and `doPluginCommand` into `doCommand`. Also updated part of `doPluginCommand` for better readibility.
…anifest accordingly
corevo
reviewed
Aug 12, 2018
| }; | ||
|
|
||
| Selenium.prototype.doEvaluateConditional = function(condition) { | ||
| return !!(this.eval(condition, undefined, true)); |
There was a problem hiding this comment.
Why not scoped?
In WebDriver it'll be scoped.
There was a problem hiding this comment.
I can make it explicit, but isn't it already scoped if it's undefined?
There was a problem hiding this comment.
Forgot it has a default value true, make it true anyway for clarification that it is required.
I put the default one, so that if it gets called from something internal that I'm not aware of, that it'll be scoped by default.
… block in the playback `executionLoop`, pushing its execution into `doSeleniumCommand`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement