Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium should announce when Recording has started #974

Merged

Conversation

ansarmie
Copy link

Thanks for contributing to the Selenium IDE!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Support Accessibility regarding Announcing that the Recording has started Issue #964

Motivation and Context

The Selenium IDE extension has some cases where some assistive technologies cannot interact with or cannot display information to the user. The idea in this PR is to add simple attributes so when the Recording session starts the user can hear it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Add aria-label and role alert to the Selenium Recording indicator.

@claassistantio
Copy link

claassistantio commented Feb 28, 2020

CLA assistant check
All committers have signed the CLA.

@tourdedave
Copy link
Contributor

👏

@tourdedave tourdedave merged commit b82fc8c into SeleniumHQ:v3 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants