added onQuit handler for chromedriver

SeleniumHQ · Sep 8, 2019 · 4e62dd5 · 4e62dd5
1 parent 5caa106
commit 4e62dd5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/javascript/node/selenium-webdriver/chrome.js b/javascript/node/selenium-webdriver/chrome.js
@@ -687,12 +687,14 @@ class Driver extends webdriver.WebDriver {
    */
   static createSession(opt_config, opt_serviceExecutor) {
     let executor;
+    let onQuit;
     if (opt_serviceExecutor instanceof http.Executor) {
       executor = opt_serviceExecutor;
       configureExecutor(executor);
     } else {
       let service = opt_serviceExecutor || getDefaultService();
       executor = createExecutor(service.start());
+      onQuit = () => service.kill();
     }
 
     let caps = opt_config || Capabilities.chrome();
@@ -707,7 +709,7 @@ class Driver extends webdriver.WebDriver {
       }
     }
 
-    return /** @type {!Driver} */(super.createSession(executor, caps));
+    return /** @type {!Driver} */(super.createSession(executor, caps, onQuit));
   }
 
   /**