Skip to content

Commit

Permalink
Unguard fixed window specs for IE
Browse files Browse the repository at this point in the history
It now supports setting size and position and maximizing windows
  • Loading branch information
p0deje committed Nov 30, 2017
1 parent 0433610 commit 5b378ca
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions rb/spec/integration/selenium/webdriver/window_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ module WebDriver
expect(size.height).to be > 0
end

it 'sets the size of the current window', except: {browser: :ie} do
it 'sets the size of the current window' do
size = window.size

target_width = size.width - 20
target_height = size.height - 20

window.size = Dimension.new(target_width, target_height)
window.size = Dimension.new(target_height)

This comment has been minimized.

Copy link
@BrianHawley

BrianHawley Nov 30, 2017

Contributor

@p0deje this change doesn't make sense, and causes the test to fail.

This comment has been minimized.

Copy link
@p0deje

p0deje Dec 1, 2017

Author Member

🤦‍♂️


new_size = window.size
expect(new_size.width).to eq(target_width)
Expand All @@ -55,7 +55,7 @@ module WebDriver
expect(pos.y).to be >= 0
end

it 'sets the position of the current window', except: {browser: %i[ie safari_preview]} do
it 'sets the position of the current window', except: {browser: :safari_preview} do
pos = window.position

target_x = pos.x + 10
Expand Down Expand Up @@ -100,7 +100,7 @@ module WebDriver
expect(new_rect.height).to eq(target_height)
end

it 'can maximize the current window', except: [{window_manager: false}, {browser: :ie}] do
it 'can maximize the current window', except: {window_manager: false} do
window.size = old_size = Dimension.new(200, 200)

window.maximize
Expand Down

0 comments on commit 5b378ca

Please sign in to comment.