Firefox: Implementing a capability that disables overlapping checks

SeleniumHQ · Feb 9, 2016 · ab99406 · ab99406
1 parent 7d06243
commit ab99406
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 3 deletions.
diff --git a/java/client/src/org/openqa/selenium/remote/CapabilityType.java b/java/client/src/org/openqa/selenium/remote/CapabilityType.java
@@ -41,6 +41,7 @@ public interface CapabilityType {
   String UNEXPECTED_ALERT_BEHAVIOUR = "unexpectedAlertBehaviour";
   String ELEMENT_SCROLL_BEHAVIOR = "elementScrollBehavior";
   String HAS_TOUCHSCREEN = "hasTouchScreen";
+  String OVERLAPPING_CHECK_DISABLED = "overlappingCheckDisabled";
 
   String LOGGING_PREFS = "loggingPrefs";
 

diff --git a/java/client/test/org/openqa/selenium/firefox/FirefoxDriverTest.java b/java/client/test/org/openqa/selenium/firefox/FirefoxDriverTest.java
@@ -48,6 +48,8 @@
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.environment.GlobalTestEnvironment;
 import org.openqa.selenium.firefox.internal.ProfilesIni;
+import org.openqa.selenium.remote.CapabilityType;
+import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.UnreachableBrowserException;
 import org.openqa.selenium.support.ui.ExpectedCondition;
 import org.openqa.selenium.support.ui.WebDriverWait;
@@ -582,6 +584,29 @@ public void searchingByCssDoesNotOverwriteExistingSizzleDefinition() {
         ((JavascriptExecutor) driver).executeScript("return window.Sizzle + '';"));
   }
 
+  @Test
+  public void testFirefoxCanNativelyClickOverlappingElements() {
+    DesiredCapabilities capabilities = new DesiredCapabilities();
+    capabilities.setCapability(CapabilityType.OVERLAPPING_CHECK_DISABLED, true);
+    WebDriver secondDriver = new FirefoxDriver(capabilities);
+    try {
+      secondDriver.get(appServer.whereIs("click_tests/overlapping_elements.html"));
+      secondDriver.findElement(By.id("under")).click();
+      assertEquals(secondDriver.findElement(By.id("log")).getText(),
+                   "Log:\n"
+                   + "mousedown in over (handled by over)\n"
+                   + "mousedown in over (handled by body)\n"
+                   + "mouseup in over (handled by over)\n"
+                   + "mouseup in over (handled by body)\n"
+                   + "click in over (handled by over)\n"
+                   + "click in over (handled by body)");
+    } finally {
+      secondDriver.quit();
+    }
+  }
+
+
+
   private WebDriver newFirefoxDriver() {
     return newFirefoxDriver(new FirefoxProfile());
   }

diff --git a/javascript/firefox-driver/js/sessionstore.js b/javascript/firefox-driver/js/sessionstore.js
@@ -167,6 +167,7 @@ wdSessionStoreService.CAPABILITY_PREFERENCE_MAPPING = {
   'applicationCacheEnabled': 'browser.cache.offline.enable',
   'databaseEnabled': 'dom.indexedDB.enabled',
   'elementScrollBehavior' : 'webdriver.elementScrollBehavior',
+  'overlappingCheckDisabled' : 'webdriver.overlappingCheckDisabled',
   'locationContextEnabled': 'geo.enabled',
   'browserConnectionEnabled': 'dom.network.enabled',
   'acceptSslCerts': 'webdriver_accept_untrusted_certs',

diff --git a/javascript/firefox-driver/js/syntheticMouse.js b/javascript/firefox-driver/js/syntheticMouse.js
@@ -83,9 +83,20 @@ SyntheticMouse.prototype.isElementShownAndClickable = function(element) {
     return error;
   }
 
-  var error = this.isElementClickable(element);
-  if (error) {
-    return error;
+  var checkOverlapping = true;
+  try {
+    var prefStore = fxdriver.moz.getService('@mozilla.org/preferences-service;1',
+                                            'nsIPrefBranch');
+    if (prefStore.getBoolPref('webdriver.overlappingCheckDisabled', false)) {
+      checkOverlapping = false;
+    }
+  } catch (ignored) {}
+
+  if (checkOverlapping) {
+    error = this.isElementClickable(element);
+    if (error) {
+      return error;
+    }
   }
 }