Skip to content

Commit

Permalink
[py] Remove thread.join in testing webserver
Browse files Browse the repository at this point in the history
Due to https://bugs.chromium.org/p/chromedriver/issues/detail?id=3654#c1
Chrome doesn't release network resources properly.
  • Loading branch information
AutomatedTester committed Nov 18, 2020
1 parent 4a3bb6d commit d6d672c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions py/test/selenium/webdriver/common/webserver.py
Expand Up @@ -55,6 +55,7 @@ def updir():

class HtmlOnlyHandler(BaseHTTPRequestHandler):
"""Http handler."""

def do_GET(self):
"""GET method handler."""
try:
Expand Down Expand Up @@ -86,6 +87,7 @@ class ThreadedHTTPServer(ThreadingMixIn, HTTPServer):

class SimpleWebServer(object):
"""A very basic web server."""

def __init__(self, host=DEFAULT_HOST, port=DEFAULT_PORT):
self.stop_serving = False
host = host
Expand Down Expand Up @@ -121,8 +123,6 @@ def stop(self):
urllib_request.URLopener().open("http://%s:%d" % (self.host, self.port))
except IOError:
pass
LOGGER.info("Shutting down the webserver")
self.thread.join()

def where_is(self, path):
return "http://%s:%d/%s" % (self.host, self.port, path)
Expand Down

0 comments on commit d6d672c

Please sign in to comment.