Skip to content

Commit

Permalink
[rb] replace erroneous em dashes with regular dash
Browse files Browse the repository at this point in the history
  • Loading branch information
lmtierney committed Aug 20, 2018
1 parent ef87df8 commit f55fd60
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions rb/lib/selenium/webdriver/edge/service.rb
Expand Up @@ -44,8 +44,8 @@ def cannot_connect_error_text

def extract_service_args(driver_opts)
driver_args = super
driver_args << "host=#{driver_opts[:host]}" if driver_opts.key? :host
driver_args << "package=#{driver_opts[:package]}" if driver_opts.key? :package
driver_args << "--host=#{driver_opts[:host]}" if driver_opts.key? :host
driver_args << "--package=#{driver_opts[:package]}" if driver_opts.key? :package
driver_args << "-verbose" if driver_opts[:verbose] == true
driver_args
end
Expand Down
6 changes: 3 additions & 3 deletions rb/lib/selenium/webdriver/firefox/service.rb
Expand Up @@ -52,9 +52,9 @@ def cannot_connect_error_text
def extract_service_args(driver_opts)
driver_args = super
driver_args << "--binary=#{driver_opts[:binary]}" if driver_opts.key?(:binary)
driver_args << "-log=#{driver_opts[:log]}" if driver_opts.key?(:log)
driver_args << "-marionette-port=#{driver_opts[:marionette_port]}" if driver_opts.key?(:marionette_port)
driver_args << "-host=#{driver_opts[:host]}" if driver_opts.key?(:host)
driver_args << "--log=#{driver_opts[:log]}" if driver_opts.key?(:log)
driver_args << "--marionette-port=#{driver_opts[:marionette_port]}" if driver_opts.key?(:marionette_port)
driver_args << "--host=#{driver_opts[:host]}" if driver_opts.key?(:host)
driver_args
end
end # Service
Expand Down
4 changes: 2 additions & 2 deletions rb/spec/unit/selenium/webdriver/edge/service_spec.rb
Expand Up @@ -58,8 +58,8 @@ module Edge
package: '/path/to/pkg',
verbose: true}

args = ["host=#{driver_opts[:host]}",
"package=#{driver_opts[:package]}",
args = ["--host=#{driver_opts[:host]}",
"--package=#{driver_opts[:package]}",
"-verbose"]

driver = Driver.new(http_client: http, driver_opts: driver_opts)
Expand Down
6 changes: 3 additions & 3 deletions rb/spec/unit/selenium/webdriver/firefox/service_spec.rb
Expand Up @@ -60,9 +60,9 @@ module Firefox
log: '/path/to/log'}

args = ["--binary=#{driver_opts[:binary]}",
"-log=#{driver_opts[:log]}",
"-marionette-port=#{driver_opts[:marionette_port]}",
"-host=#{driver_opts[:host]}"]
"--log=#{driver_opts[:log]}",
"--marionette-port=#{driver_opts[:marionette_port]}",
"--host=#{driver_opts[:host]}"]

driver = Driver.new(http_client: http, driver_opts: driver_opts)
expect(driver.instance_variable_get("@service").instance_variable_get("@extra_args")).to eq args
Expand Down

0 comments on commit f55fd60

Please sign in to comment.