New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃殌 Feature]: Killing Sessions via UI #11519
Comments
@shmikkil, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
This could make sense. However, I would only enable that feature if the Grid is password protected or under a specific flag. Otherwise, anyone could delete any session and this might be annoying in shared Grids. Please note that it is only possible to stop idle sessions, if a session is stuck in a request, the request needs to timeout before any action can be taken. You can always tune the session timeout to reduce this type of situation. |
This issue is looking for contributors. Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested. |
Awesome...Glad to hear that! And yes, just going with a default pwd at the moment. Come to think of it, perhaps we should have another enhancement request where there should be an ability for the admins to assign creds to a specific group that could delete/maintain while the end-users who run the tests to be assigned to another group that simply can access the sessions during runtime to view the execution via the UI as well. Would that be helpful? |
I do not think Grid should start managing user profiles and passwords, that requires storage and managing those credentials very carefully. For now, Grid offers basic auth with a single user and password. That type of feature is out of scope. |
Thanks for the clarification! |
@diemol - Basic question around this. If a session is stuck due to whatever reasons (for e.g., the client died/was killed) then wouldn't the session eventually timeout because the guava cache in LocalNode has a listener which seems to be triggering a delete session request for sessions that are about to be evicted.
|
@krmahadevan yes, eventually the timeout will kick in and stop the session.
I see as the use case where a session was started with the wrong parameters and you do not want to wait until the timeout kicks in. An Appium session for example.
The cleanup mechanism for timeout only kicks in when the timeout happens, so this new feature would just be a nice thing to have when one wants to stop the session. |
Ok. In that case, it would just boil down to invoking the DELETE session api (endpoint: |
That also works. However, the idea would be to have it as an option from the UI (under a flag or so). |
Any update on this enhancement request? |
@shmikkil feel free to send a pull request to help us out! We are a group where most of the members are volunteers. If you need help to get started, please join our Slack channel https://www.selenium.dev/support/ |
until this is done is there a way to get all sessions related to a node uri ? Then we could just hit this api in a loop to delete all sessions @diemol |
You can send a
|
Also, check the available endpoints here https://www.selenium.dev/documentation/grid/advanced_features/endpoints/ |
Thanks, but for this sessionId is still needed. I'm just looking for a way to get all sessionId's. |
Did you check what the |
Got it thanks, |
Hi @diemol , I tried something and want to test by building locally, since in standalone react server sessions wont be there. |
Feature and motivation
We are using k8s grid 4 and have the pods up and running all the time. It's a hassle to delete the pods that're stuck when sessions time out or when end-users doesn't close their sessions after the tests were executed. Any way we can add this feature to delete/remove sessions via the UI Console by right-clicking each of these sessions and remove them? Thank You!
Usage example
Right click on individual session IDs that are long running and delete/remove them.
The text was updated successfully, but these errors were encountered: