Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃殌 Feature]: Use latest 18.x version #13344

Open
apupier opened this issue Dec 21, 2023 · 6 comments
Open

[馃殌 Feature]: Use latest 18.x version #13344

apupier opened this issue Dec 21, 2023 · 6 comments
Labels
C-build Build related issues (bazel and CI) C-nodejs help wanted Issues looking for contributions I-enhancement

Comments

@apupier
Copy link
Contributor

apupier commented Dec 21, 2023

Feature and motivation

follow-up #12723

I think it will be nice to have it working with latest 18.x as currently blocked on 18.17.0

node_version = "18.17.0",
which is the latest version supported by bazelbuild/rules_nodejs 5.8.4 which is the latest 5.x version.

Usage example

It will allow to test with the LTS version which receives security updates.

Copy link

@apupier, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@apupier apupier changed the title [馃殌 Feature]: Launch tests with latest 18.x version [馃殌 Feature]: Use latest 18.x version Dec 21, 2023
apupier added a commit to apupier/selenium that referenced this issue Dec 21, 2023
- upgrade to new version of bazel node JS rule to have it supported

fixes SeleniumHQ#13344

Signed-off-by: Aur茅lien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Dec 21, 2023

bazelbuild/rules_nodejs 6 has a reduced scope https://github.com/bazelbuild/rules_nodejs/tree/main#60-scope-reduction

aspect-build/rules_js is claiming to be an alternative https://github.com/aspect-build/rules_js#relationship-to-rules_nodejs

apupier added a commit to apupier/selenium that referenced this issue Dec 21, 2023
- move from rules_nodejs to rules_js to have it supported

fixes SeleniumHQ#13344

Signed-off-by: Aur茅lien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Dec 21, 2023

attempt to migrate: https://github.com/apupier/selenium/tree/13344-useLatest18 but currently failing with:

(base) apupier@localhost:~/git/selenium$ bazel build javascript/...
ERROR: Skipping 'javascript/...': error loading package under directory 'javascript': error loading package 'javascript/grid-ui': Unable to find package for @npm//react-scripts:index.bzl: The repository '@npm' could not be resolved: Repository '@npm' is not defined.
WARNING: Target pattern parsing failed.
ERROR: error loading package under directory 'javascript': error loading package 'javascript/grid-ui': Unable to find package for @npm//react-scripts:index.bzl: The repository '@npm' could not be resolved: Repository '@npm' is not defined.
INFO: Elapsed time: 0.094s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: javascript/chrome-driver ... (7 packages)

@titusfortner
Copy link
Member

Yes, migrating to rules_js is on our list of things to do:
https://github.com/orgs/SeleniumHQ/projects/2?pane=issue&itemId=43566772

@titusfortner
Copy link
Member

If you can help assist/collaborate on the move, come find us in Selenium Chat and we can discuss: https://www.selenium.dev/support/#ChatRoom

@titusfortner titusfortner added C-nodejs C-build Build related issues (bazel and CI) help wanted Issues looking for contributions and removed needs-triaging labels Dec 31, 2023
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI) C-nodejs help wanted Issues looking for contributions I-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants