-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃悰 Bug]: Defaulting the Firefox binary to firefox-bin
fails to start Firefox 121 and later
#13350
Comments
@whimboo, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Note that on MacOS you should read the actual binary from the |
CC maintainers of Selenium to make them aware of the current breakage with Firefox 121. |
Well, Selenium Manager does the right thing, so that's a good first step. It looks like we support a user passing in the full path to the binary, which we can't fix, but some languages also support passing in the directory and adding the binary to it. How long has |
I don't think Selenium should be reading from anything. I'm not even sure the code should be looking inside a provided directory. Maybe this is a good excuse to deprecate the various FirefoxBinary classes. We needed them in Selenium 2, we do not need them in Selenium 4. |
Maybe but I cannot talk about other drivers beside geckodriver. At least on our side you can specify an app bundle and we will resolve the binary automatically. Which versions of Selenium are directly affected by this problem? I'm asking because you say that those classes are not needed for Selenium 4. |
Both binaries basically exist forever and |
I had a look at the code base, and we have a few places where
However, those are all helper classes, and they are not needed for recent versions of Selenium, more specifically because they were used when GeckoDriver was not around and Selenium was doing the heavy lifting. Users can always:
What we can do in Selenium, is to update those mentions of |
@diemol I know you deprecated these helpers, should we also change firefox-bin until we remove them? |
I changed the |
There were still 2 references still the last time I searched. Not at the code right now. |
So, I think this is done. The helpers will be removed after 2 releases per our policy. |
I did not change the ones in Python because I wanted to deprecate the |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
With the Firefox 121 release several Selenium bindings are not able to start Firefox via geckodriver because the default Firefox binary as found by Selenium will be used by specifying the
firefox-bin
binary instead of justfirefox
. We got this report earlier today via @soulgalore on mozilla/geckodriver#2144.As it looks like several bindings use
firefox-bin
and need to be corrected to usefirefox
instead:https://github.com/search?q=repo%3ASeleniumHQ%2Fselenium+firefox-bin&type=code
How can we reproduce the issue?
Relevant log output
There is no output but the process gets immediately killed because of https://bugzilla.mozilla.org/show_bug.cgi?id=1871447.
Operating System
MacOS (all versions)
Selenium version
Most recent
What are the browser(s) and version(s) where you see this issue?
Firefox 121 and later
What are the browser driver(s) and version(s) where you see this issue?
geckodriver 0.33.0
Are you using Selenium Grid?
No
The text was updated successfully, but these errors were encountered: