-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geckodriver can't start Firefox 121 on Mac when Contents/MacOS/firefox-bin
is used
#2144
Comments
Thanks @soulgalore. Would you mind running again with the trace logs enabled? I do not see any output from Firefox in the above pasted log. It's all only from geckodriver. I can see that you are using a special profile. Does it also happen with a default one as created by geckodriver? |
I tried this:
And the log from Geckodriver:
|
We started a discussion on Matrix in the browsertime channel. We are going to post an update once we have more information. |
Hi, got the same problem, all tests now are not starting:
|
@tomak do you have some more details of what you are running? Which OS version etc? Where is Firefox installed? Does it fail in both headless and headfull mode? Also I would be kinda interested in the Firefox logs that should be visible but so far we were not able to get these. Even not when running WebDriver commands directly with |
Also if the 120 release is still working fine for you maybe you could check for a regression range with the help of mozregression? A command like the following will do the checks on its own when you pass in a Selenium script that fails:
If you cannot pass-in the binary that way you can read the value from the |
I tested a couple of things:
|
I'm also having problems on a Mac M2. Wont bother adding to the noize but can test any potential fixes if that helps. |
Same here. Selenium tests are failing with 121, 120.0.1 works. |
@soulgalore mozregression might actually download Nighltly builds directly. Please check the first lines of the log output. This is really strange! So I can perfectly run
Also does the crash happen with beta releases? Those can also be found under https://archive.mozilla.org/pub/firefox/releases/. Please definitely check the 121.0b1 first. |
|
Hi, we think it is nto related to specific setup but just firefox 121 + gecko driver 033 is corrupted.
|
Same problem with
Is there any workaround apart from downgrading? |
Could you please check if the 121b1 release is also affected? |
Yes, it seems also affected. (I renamed the current Firefox in Applications and put the 121b1 there with the name |
That's correct. So given that 121.0b1 is affected as well I would like to know now if a Nightly build of Firefox shows the same problem. Therefore can you please test the latest Firefox Nightly build from Nov 20th? |
I get the same with Nightly 123.0a1 (2023-12-21). Ok I actually got it to work :D I think Selenium automatically sets the paths with the firefox-bin? Has anything changed with that for the latest release? |
Ok, I can confirm the above:
|
There may be an additional issue involved here: |
I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1871447 for the regression in Firefox. We most likely will have to fix it as well for geckodriver. But not sure if we can get a quick bug fix release out. I'm going to investigate and will file a bug as well. |
Contents/MacOS/firefox-bin
is used
I've filed an issue for Selenium so that they no longer default to |
I'm going to take care of geckodriver over on https://bugzilla.mozilla.org/show_bug.cgi?id=1871458. |
As we noticed together with the Selenium team the issue only occurs when tests / clients use the old helper functions for Firefox instead of the Selenium Manager. So if you are impacted please switch over to using the Selenium Manager for browser management, or specify the path to the binary yourself. |
Filed a Mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=1872516 for MacOS hang-on-startup headless regression. |
Thanks for investigating and filing the issue! Lets see that we can get it fixed as well, but it's indeed unrelated to this particular issue. |
Interestingly it fails for me with
|
@mikz when you are running the test can you please check the output in the |
Anyone affected by this problem could you please try a nightly build of the upcoming geckodriver 0.34.0? Does it fix the issue for you? |
Yes! Thanks. |
Yes. It seems that Firefox has been launched successfully. environment
geckodriver version
execute geckodriver
send request to geckodriver
resultgeckodriver's log
curl result
|
That's great and thanks for the confirmation. As such I'm going ahead and will release the version today. |
@whimboo I'm starting geckodriver with
And trying it with the latest geckodriver nightly works!
and the releveant console.app log
Indeed it tries to launch Thank you! |
geckodriver 0.34.0 has been released: |
Mine still fails due to https://bugzilla.mozilla.org/show_bug.cgi?id=1872516 |
Right, but that's unrelated to the fix in geckodriver. And we have to wait until the developer is back before we can make progress on it. So please be patient for some more days. Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Please don't continue to add comments here given that those are unrelated to this issue. Use #2186 instead. Thanks. |
System
This happens both on Mac M1 and AMD. This seems to work on Ubuntu where I have 121 up and running.
Testcase
Stacktrace
[2023-12-20 05:52:26] INFO: firefox failed to start, trying 0 more time(s): Process unexpectedly closed with status signal
Geckodriver log:
See sitespeedio/browsertime#2041
The text was updated successfully, but these errors were encountered: