-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium doesn't display the stacktrace from geckodriver exceptions, because the key is cased differently #3683
Comments
@AutomatedTester this needs attention. |
Any feedback on this issue? |
Looks like a legitimate issue that we need to address in all languages, would like confirmation from one of the spec leads @AutomatedTester or @shs96c |
We're going to have to update the spec to do |
…cktrace reported by a remote WebDriver endpoint (if any) #3683
Java handles both protocol versions. |
f4bd516 fixes in Ruby bindings. |
b8af26b fixes in Python |
Closing as the fix got implemented/merged in all bindings. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Meta -
OS: Linux (Ubuntu 14.04)
Selenium Version:
3.3.1
Browser:
Firefox / geckodriver 0.15.0
Expected Behavior -
If geckodriver throws an exception with a stacktrace, selenium should display that stacktrace in the message for the WebDriverException it generates.
Actual Behavior -
The message is empty, even if a stacktrace is present.
It seems the selenium code looks for the key 'stackTrace' in an exception JSON passed from a webdriver. See https://github.com/SeleniumHQ/selenium/blob/master/py/selenium/webdriver/remote/errorhandler.py#L173 However geckodriver uses 'stacktrace', all lower case, as per the W3 spec: https://www.w3.org/TR/webdriver/
I haven't checked every single one, but other languages appear to do the same thing. Would a PR checking for both keys be accepted? If so, is it legit to just patch one language's code, or does this cause more problems than it solves? Thanks.
The text was updated successfully, but these errors were encountered: