Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium doesn't display the stacktrace from geckodriver exceptions, because the key is cased differently #3683

Closed
jwg4 opened this issue Mar 20, 2017 · 9 comments
Labels

Comments

@jwg4
Copy link

jwg4 commented Mar 20, 2017

Meta -

OS: Linux (Ubuntu 14.04)
Selenium Version:
3.3.1
Browser:
Firefox / geckodriver 0.15.0

Expected Behavior -

If geckodriver throws an exception with a stacktrace, selenium should display that stacktrace in the message for the WebDriverException it generates.

Actual Behavior -

The message is empty, even if a stacktrace is present.

It seems the selenium code looks for the key 'stackTrace' in an exception JSON passed from a webdriver. See https://github.com/SeleniumHQ/selenium/blob/master/py/selenium/webdriver/remote/errorhandler.py#L173 However geckodriver uses 'stacktrace', all lower case, as per the W3 spec: https://www.w3.org/TR/webdriver/

I haven't checked every single one, but other languages appear to do the same thing. Would a PR checking for both keys be accepted? If so, is it legit to just patch one language's code, or does this cause more problems than it solves? Thanks.

@isaulv
Copy link
Contributor

isaulv commented Apr 18, 2017

@AutomatedTester this needs attention.

@jwg4
Copy link
Author

jwg4 commented Jun 13, 2017

Any feedback on this issue?

@lmtierney
Copy link
Member

Looks like a legitimate issue that we need to address in all languages, would like confirmation from one of the spec leads @AutomatedTester or @shs96c

@AutomatedTester
Copy link
Member

We're going to have to update the spec to do stackTrace. We are also going to have to update the bindings for a short term to handle both stacktrace and stackTrace

jleyba added a commit that referenced this issue Jul 5, 2017
…cktrace

reported by a remote WebDriver endpoint (if any)

#3683
@barancev
Copy link
Member

Java handles both protocol versions.

@barancev barancev removed the C-java label Aug 15, 2017
p0deje added a commit that referenced this issue Aug 16, 2017
@p0deje
Copy link
Member

p0deje commented Aug 16, 2017

f4bd516 fixes in Ruby bindings.

@p0deje p0deje removed the C-rb label Aug 16, 2017
Tom-Trumper pushed a commit to Tom-Trumper/selenium that referenced this issue Sep 11, 2017
topherbullock pushed a commit to topherbullock/selenium that referenced this issue Oct 4, 2017
@jleyba jleyba removed the C-nodejs label Oct 25, 2017
@lmtierney
Copy link
Member

b8af26b fixes in Python

@diemol
Copy link
Member

diemol commented Apr 12, 2020

Closing as the fix got implemented/merged in all bindings.

@diemol diemol closed this as completed Apr 12, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants