Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow childprocess 1.0 dependency of ruby selenium-webdriver? #6907

Closed
jrochkind opened this issue Feb 1, 2019 · 3 comments
Closed

Allow childprocess 1.0 dependency of ruby selenium-webdriver? #6907

jrochkind opened this issue Feb 1, 2019 · 3 comments
Labels
C-rb

Comments

@jrochkind
Copy link

Ruby gem selenium-webdriver has a dependency on 'childprocess', ['~> 0.5']

selenium/rb/selenium-webdriver.gemspec

Line 33 in d7674b0

s.add_runtime_dependency 'childprocess', ['~> 0.5']

The childprocess gem had a 1.0 release a couple days ago. That is not allowed by the selenium-webdriver dependency specification.

Should it be?
@barancev barancev added the C-rb label Feb 1, 2019
@titusfortner
Copy link
Member

It looks like 1.0 is just support for later jruby versions, so probably no reason to limit it. Thanks for the heads up.

@tiagoamaro tiagoamaro mentioned this issue Feb 14, 2019
Merged
twalpole added a commit to twalpole/selenium that referenced this issue Feb 21, 2019
@twalpole
Allow childprocess 1.x - issue SeleniumHQ#6907
fcbf933
twalpole added a commit that referenced this issue Feb 21, 2019
@twalpole
Allow childprocess 1.x - issue #6907 (#6948)
6d7f633
@twalpole
Copy link
Contributor

Fixed via 6d7f633

@jrochkind
Copy link
Author

thanks!

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-rb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@twalpole @jrochkind @barancev @titusfortner