Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: Modifies install_addon method to support installing unpacked addons #10308

Merged
merged 8 commits into from
Mar 1, 2022

Conversation

gpt14
Copy link
Contributor

@gpt14 gpt14 commented Jan 30, 2022

Description

Modifies install_addon method to support installing unpacked addons

Motivation and Context

implements #10265

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #10308 (53c7508) into trunk (d17db9d) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk   #10308      +/-   ##
==========================================
+ Coverage   44.97%   44.99%   +0.02%     
==========================================
  Files          85       85              
  Lines        5479     5489      +10     
  Branches      269      269              
==========================================
+ Hits         2464     2470       +6     
- Misses       2746     2750       +4     
  Partials      269      269              
Impacted Files Coverage Δ
py/selenium/webdriver/firefox/webdriver.py 32.63% <50.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f7dde...53c7508. Read the comment docs.

@gpt14
Copy link
Contributor Author

gpt14 commented Feb 2, 2022

@titusfortner - please review

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 8a23bca into SeleniumHQ:trunk Mar 1, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…ns (SeleniumHQ#10308)

* py: Modifies install_addon method to support installing unpacked addons

* Fix lint

* adds copy_file block to increase code readability

* Fix lint

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants