Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] fix screen rotate error #10693

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

fanjlii
Copy link
Contributor

@fanjlii fanjlii commented May 26, 2022

Description

The implemetion of rotate command may be wrong in java client, SET_SCREEN_ORIENTATION has beeing used twice, but SET_SCREEN_ROTATION has never been used.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented May 26, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this has not been an issue because it looks like no one is using this. Giving that there is (probably) no support for it in browsers. We will likely remove this soon.

However, for the sake of correctness, let's merge this :)

Thank you, @fanjlii!

@codecov-commenter
Copy link

Codecov Report

Merging #10693 (00cde25) into trunk (9a43c53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10693   +/-   ##
=======================================
  Coverage   46.61%   46.61%           
=======================================
  Files          86       86           
  Lines        5848     5848           
  Branches      278      278           
=======================================
  Hits         2726     2726           
  Misses       2844     2844           
  Partials      278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a43c53...00cde25. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diemol diemol merged commit bc1b4f0 into SeleniumHQ:trunk May 26, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants