[IEDriver] fix Edge IE mode issue that sometimes cannot get the handle of a newly opened window #10702

yusuke-noda · 2022-05-27T07:46:42Z

Description

Fix Edge IE mode issue that sometimes cannot get the handle of the newly opened window.

Motivation and Context

This is a fix for an issue of Edge IE mode that sometimes cannot get the handle of a newly opened window.
Resolve #8868
Resolve MicrosoftEdge/EdgeWebDriver#19

Reproduction steps

Attached zip file contains test programs to reproduce of the issue.
iedrivertest.zip

Install node_modules
npm install
Run server.
node server.js
Run tests several times.
node test.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"
node test2.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"
node test3.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"
node test4.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"
node test5.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"

Contents of test programs

test.js
Open one child window and check that can get window handle of the child window.
test2.js
Open four child window and check that can get window handles of all of the child windows.
test3.js
Open four child tabs in the same window that contains the parent tab and check that can get window handles of all of the child tabs.
test4.js
Open child window and its grandchild window at same time and close child window immediately, then check that can get window handle of grandchild windows.
test5.js
Open child window and its grandchild window at same time, then check that can get window handle of child and grandchild windows.

Unresolved problem

Open child and its grandchild tabs in the same window that contains the parent tab at same time, IEDriver cannot get window handle of the child tab.
node test6.js --edge-path "path\to\msedge.exe" --driver-path "path\to\IEDriverServer.exe"

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

… to appear. A part of the fixes for issues that occur in Edge IE mode. There is a thread that uses SendMessage to send WM_USER in the mouse click process, and this thread goes into a wait state. If this is not done, the new browser window will never be displayed. Therefore, you need to process the WM_USER message while waiting for a new window to appear.

…hing to the window. A part of the fixes for issues that occur in Edge IE mode. When a new browser window appears and closes immediately, IEDriver may try to attach to a window that doesn't exist. To solve this problem, check that the window process exists before attaching to the window.

…d window. A part of the fixes for issues that occur in Edge IE mode. If the grandchild window opens before it is attached to the child window, IEDriver cannot detect the appearance of the grandchild window. Therefore, if a child window and a grandchild window appear at the same time, the handle of the grandchild window cannot be obtained. To solve this problem, add wait to wait for the grandchild window to appear, and attach to all elements of diff list.

CLAassistant · 2022-05-27T07:46:47Z

All committers have signed the CLA.

ven92 · 2022-06-09T07:04:01Z

I'm facing the same issue. I tried with IE driver v4.0 & v4.2. MS Edge is getting launched in IE Mode, window handle works when only one Window present. But if multiple window gets open, then the code get stuck at driver.window_handles line. Could you please provide the ASAP..

JeyBee83 · 2022-06-23T05:50:13Z

Any updates on this? A merge would be very helpful, we have lots of issues with this.

bwalderman · 2022-06-27T16:48:59Z

When I built and tested IEDriverServer this change, I found that test.js, test2.js and test3.js are more stable, but test4.js and test5.js are still failing. @yusuke-noda does this match your expectations?

Log from test4.js:

> node .\test4.js --driverPath=IEDriverServer.exe --edgePath="C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
start
iteration start 0
retry
retry
retry
Error: too many retry
    at C:\Users\brwalder\Desktop\iedrivertest\test4.js:51:17
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
finally

Log from test5.js:

> node .\test5.js --driverPath=IEDriverServer.exe --edgePath="C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
start
iteration start 0
retry
retry
retry
Error: too many retry
    at C:\Users\brwalder\Desktop\iedrivertest\test5.js:51:17
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
finally

yusuke-noda · 2022-06-28T02:36:45Z

Hello @bwalderman .
On my environments (Windows 10 21H2 and Windows 11), test4.js and test5.js are also stable.

node .\test4.js --driver-path .\IEDriverServer.exe --edge-path "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
start
iteration start 0
iteration finished 0
iteration start 1
iteration finished 1
iteration start 2
iteration finished 2
iteration start 3
iteration finished 3
iteration start 4
iteration finished 4
iteration start 5
iteration finished 5
iteration start 6
iteration finished 6
iteration start 7
iteration finished 7
iteration start 8
iteration finished 8
iteration start 9
iteration finished 9
iteration start 10
iteration finished 10
iteration start 11
iteration finished 11
iteration start 12
iteration finished 12
iteration start 13
iteration finished 13
iteration start 14
iteration finished 14
iteration start 15
iteration finished 15
iteration start 16
iteration finished 16
iteration start 17
iteration finished 17
iteration start 18
iteration finished 18
iteration start 19
iteration finished 19
finally

node .\test5.js --driver-path .\IEDriverServer.exe --edge-path "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
start
iteration start 0
[ 'child51', 'child52' ]
iteration finished 0
iteration start 1
[ 'child51', 'child52' ]
iteration finished 1
iteration start 2
[ 'child51', 'child52' ]
iteration finished 2
iteration start 3
[ 'child51', 'child52' ]
iteration finished 3
iteration start 4
[ 'child51', 'child52' ]
iteration finished 4
iteration start 5
[ 'child51', 'child52' ]
iteration finished 5
iteration start 6
[ 'child51', 'child52' ]
iteration finished 6
iteration start 7
[ 'child51', 'child52' ]
iteration finished 7
iteration start 8
[ 'child51', 'child52' ]
iteration finished 8
iteration start 9
[ 'child51', 'child52' ]
iteration finished 9
iteration start 10
[ 'child51', 'child52' ]
iteration finished 10
iteration start 11
[ 'child51', 'child52' ]
iteration finished 11
iteration start 12
[ 'child51', 'child52' ]
iteration finished 12
iteration start 13
[ 'child51', 'child52' ]
iteration finished 13
iteration start 14
[ 'child51', 'child52' ]
iteration finished 14
iteration start 15
[ 'child51', 'child52' ]
iteration finished 15
iteration start 16
[ 'child51', 'child52' ]
iteration finished 16
iteration start 17
[ 'child51', 'child52' ]
iteration finished 17
iteration start 18
[ 'child51', 'child52' ]
iteration finished 18
iteration start 19
[ 'child51', 'child52' ]
iteration finished 19
finally

But if "Always open pop-ups in a new tab" option is enabled in IE's tabbed Browsing Settings, test5.js fails same as test6.js

Oleksii-tmnas · 2022-07-04T14:09:33Z

hey guys any updates on this? looking forward to the changes to be merged...

bwalderman · 2022-07-08T18:00:50Z

The "Always open pop-ups in a new tab" setting isn't visible in my Windows 11 environment anymore, probably because of the IE11 removal. So I can't verify that test5.js and test6.js would be fixed. However, the change looks good to me and the other test cases appear to be stable.

I've just left a couple suggestions to rename variables to match the style used in the rest of the code.

cpp/iedriver/IECommandExecutor.cpp

diemol

Thanks for reviewing, @bwalderman!

Thank you for this PR, @yusuke-noda!

titusfortner · 2022-07-14T18:27:28Z

IE Driver 4.3 is released - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.3.0

anishamarotkar · 2022-09-28T09:59:59Z

With Selenium Java version 4.4.0 or 4.3.0 and IE Driver 4.3.0 I am still getting facing the same issue. Can anyone please help?

jyosha3 · 2022-11-22T11:36:05Z

getting the same issue with latest versions of IE driver and selenium java versions.Any one was able to find a solution or workaround?

titusfortner · 2022-11-22T20:28:00Z

@anishamarotkar & @jyosha3 can you comment on MicrosoftEdge/EdgeWebDriver#19 we may need to re-open that.

jyosha3 · 2022-11-23T18:28:41Z

@titusfortner Yes did comment on that issue just now.How can it be reopened though.I am new and came here looking for a solution so dont know how things work here.

titusfortner · 2022-11-23T19:52:05Z

Yeah, since IEDriver is *only supported via Edge right now, the code management is being done in collaboration with Microsoft. So the current practice (subject to change) is to file the issue in MicrosoftEdge repo, and then the PRs are done here. @bwalderman is the person who would be able to re-open that issue. Also, you might need to provide more info with a trace log in a reproducible case if it is at all different from what has been previously reported.

jyosha3 · 2022-11-24T05:27:46Z

@titusfortner ok .. thanks for the information.. i have provided a test scenario in the microsoft edge repo.. alongwith the exception i gt. @bwalderman do I need to provide any more details for u to reopen / address the issue.

tenisaname · 2024-02-21T12:00:00Z

Hello, are there any changes on this issue?

yusuke-noda added 3 commits May 18, 2022 13:59

Merge branch 'trunk' into fix_iedriver_edgeiemode

981fa2e

diemol mentioned this pull request Jun 9, 2022

IWebDriver.WindowHandles in Selenium 4 does not return correct number of open browser windows MicrosoftEdge/EdgeWebDriver#19

Closed

bwalderman approved these changes Jul 8, 2022

View reviewed changes

cpp/iedriver/IECommandExecutor.cpp Outdated Show resolved Hide resolved

cpp/iedriver/IECommandExecutor.cpp Outdated Show resolved Hide resolved

cpp/iedriver/IECommandExecutor.cpp Outdated Show resolved Hide resolved

rename variables to match the style used in the rest of the code.

145c6b5

diemol approved these changes Jul 12, 2022

View reviewed changes

Merge branch 'trunk' into fix_iedriver_edgeiemode

f0fc9a8

diemol merged commit 7296782 into SeleniumHQ:trunk Jul 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IEDriver] fix Edge IE mode issue that sometimes cannot get the handle of a newly opened window #10702

[IEDriver] fix Edge IE mode issue that sometimes cannot get the handle of a newly opened window #10702

yusuke-noda commented May 27, 2022

CLAassistant commented May 27, 2022 •

edited

ven92 commented Jun 9, 2022

JeyBee83 commented Jun 23, 2022

bwalderman commented Jun 27, 2022

yusuke-noda commented Jun 28, 2022

Oleksii-tmnas commented Jul 4, 2022

bwalderman commented Jul 8, 2022

diemol left a comment

titusfortner commented Jul 14, 2022

anishamarotkar commented Sep 28, 2022

jyosha3 commented Nov 22, 2022

titusfortner commented Nov 22, 2022

jyosha3 commented Nov 23, 2022

titusfortner commented Nov 23, 2022

jyosha3 commented Nov 24, 2022

tenisaname commented Feb 21, 2024

[IEDriver] fix Edge IE mode issue that sometimes cannot get the handle of a newly opened window #10702

[IEDriver] fix Edge IE mode issue that sometimes cannot get the handle of a newly opened window #10702

Conversation

yusuke-noda commented May 27, 2022

Description

Motivation and Context

Reproduction steps

Contents of test programs

Unresolved problem

Types of changes

Checklist

CLAassistant commented May 27, 2022 • edited

ven92 commented Jun 9, 2022

JeyBee83 commented Jun 23, 2022

bwalderman commented Jun 27, 2022

yusuke-noda commented Jun 28, 2022

Oleksii-tmnas commented Jul 4, 2022

bwalderman commented Jul 8, 2022

diemol left a comment

Choose a reason for hiding this comment

titusfortner commented Jul 14, 2022

anishamarotkar commented Sep 28, 2022

jyosha3 commented Nov 22, 2022

titusfortner commented Nov 22, 2022

jyosha3 commented Nov 23, 2022

titusfortner commented Nov 23, 2022

jyosha3 commented Nov 24, 2022

tenisaname commented Feb 21, 2024

CLAassistant commented May 27, 2022 •

edited