Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable testGetValueOfUserDefinedProperty test for Firefox #11046

Merged
merged 2 commits into from Sep 20, 2022

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Sep 20, 2022

This Java test got fixed in Firefox 105:
https://bugzilla.mozilla.org/show_bug.cgi?id=1398792

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@whimboo
Copy link
Contributor Author

whimboo commented Sep 20, 2022

The other Java test failure for Firefox is something else and not related to my PR:
https://github.com/SeleniumHQ/selenium/actions/runs/3092477186/jobs/5004009345

@titusfortner and @diemol who can review and merge this PR? Thanks.

@titusfortner
Copy link
Member

I got it; I'm in at a work summit this week, so everything will be delayed more than usual. :-D

@titusfortner titusfortner merged commit 1a73c3f into SeleniumHQ:trunk Sep 20, 2022
@whimboo whimboo deleted the java_element_property branch September 20, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants