[java] use the correct base64 decoder

[joerg1985]

Description

Use the correct base64 decoder (RFC4648) as defined by the WebDriver specification.

Motivation and Context

Selenium should follow the WebDriver specification

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

Base: 52.31% // Head: 52.31% // No change to project coverage 👍

Coverage data is based on head (2d148c7) compared to base (9e91560).
Patch has no changes to coverable lines.

❗ Current head 2d148c7 differs from pull request most recent head cf4986f. Consider uploading reports for the commit cf4986f to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11107   +/-   ##
=======================================
  Coverage   52.31%   52.31%           
=======================================
  Files          82       82           
  Lines        5503     5503           
  Branches      198      198           
=======================================
  Hits         2879     2879           
  Misses       2426     2426           
  Partials      198      198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[pujagani]

Thank you @joerg1985 !

[weikilla]

hi , why do this change? i am using appium java client, which is depend on this project. but currently, when i call screenshot method, will throw Illegal base64 character xxx, i found the root cause is this change.

[joerg1985]

@weikilla the W3C WebDriver specification does specify the Base64 decoder to use, see: https://www.w3.org/TR/webdriver/#index

I think you should open a ticket at appium to get this fixed in the corresponding driver.
Alternatively they could overwrite the selenium implemenation, if they need a none W3C compliant implementation.

Just my two cents, the selenium team might have a different opinion on this 😄

[mykola-mokhnach]

This change will break the backward compatibility between following java client versions and existing Appium drivers. We'd have to hack this implementation in Appium java client to workaround it.

Even if we update the thing for multiple drivers, existing versions of them stay unchanged and there would be a mess.

cc @diemol @titusfortner @valfirst @SrinivasanTarget

[titusfortner]

@mykola-mokhnach can you please create an issue to make sure we track this? I don't understand the difference in implementations, so I'd vote for reverting it in the next release and figuring out a better path forward if we need to make the change.

[mykola-mokhnach]

@titusfortner created #11168