[java] Make sure EventFiringWebElement implements all WebElement methods
#11144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
valfirst
deleted the
make-sure-eventfiringeebelement-implements-all-methods-from-webelement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EventFiringWebElementshould implement allWebElementmethods:WebElementdefault implementations throw exception, butEventFiringWebElementshould perform delegation. (See similar fix: #9394).Motivation and Context
Despite the fact
EventFiringWebDriveris deprecated, it's still in use and can't be replaced easily. NewEventFiringDecoratordoesn't work well for all cases yet (e.g. appium/java-client#1694 (comment)).Types of changes
Checklist