Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] make relative_locator errors meaningful #11284

Merged
merged 1 commit into from Nov 21, 2022
Merged

[py] make relative_locator errors meaningful #11284

merged 1 commit into from Nov 21, 2022

Conversation

jaredwebber
Copy link
Contributor

Small copy changes to relative_locator error messages.

Description

Previously all errors for missing parameters in relative_locator.py returned "Element or locator must be given when calling above method", regardless whether calling function was above, below, to_left_of, to_right_of, or near.

Updated error messages to reflect the calling function.

Motivation and Context

Makes errors meaningful, clarifies debugging.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you, @jaredwebber!

@diemol diemol merged commit 6ddaaf3 into SeleniumHQ:trunk Nov 21, 2022
@jaredwebber jaredwebber deleted the fix-relative-locator-errors-py branch November 21, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants