Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Allow Selenium Manager to be used as a Rust lib crate (#11132) #11371

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR refactors the Selenium Manager Rust logic to be used as lib crate (see reference for publishing Rust crates in crates.io).

Motivation and Context

This PR implements #11132. Moreover, this PR prepares the Selenium Manager logic for M3, devoted to rich configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol previously requested changes Dec 9, 2022
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, everything else looks fine. It is a refactoring in the end.

rust/Cargo.toml Outdated Show resolved Hide resolved
@bonigarcia bonigarcia merged commit 65e3eb6 into trunk Dec 9, 2022
@bonigarcia bonigarcia deleted the se_mgr_lib branch December 9, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants