Fix description of move_to_element_with_offset #11402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
symonk
requested changes
Dec 12, 2022
Fix the function comments according to the w3c spec: https://w3c.github.io/webdriver/#dfn-dispatch-a-pointermove-action Fixes #10261
lhelwerd
added a commit
to grip-on-software/visualization-site
that referenced
this pull request
Jun 1, 2023
- Upgrade Python to 3.9 now that cffi provides musllinux packages - Upgrade Selenium standalone Chrome to 4.8.1 for newer ESM support - Run tests in verbose mode and update one Selenium import - Update find_elements?_by_.*(...) calls to find_elements?(By..., ...) since SeleniumHQ/selenium#10712 - Close driver during teardown even when there is no result outcome, to avoid keeping connections open for too long - Add remote connection timeout to detect connection issues earlier per SeleniumHQ/selenium#11596 - Remove some Python 2 import attempt - Axe report: Do not exit out if file does not exist - Adjust move_to_element_with_offset calls to work in center element, based on SeleniumHQ/selenium#11402 - Quit driver and set to None at teardown. This should properly close the session, allowing the connection to be reused for another test. - Update browser-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the function comments according to the w3c spec:
https://w3c.github.io/webdriver/#dfn-dispatch-a-pointermove-action
Fixes #10261
Description
This commit fixes the incorrect function description of
move_to_element_with_offset, which has caused confusion in issue #10261.Motivation and Context
The current code behaves correctly (following w3c spec), but the comment is incorrect.
Documentation fix: SeleniumHQ/seleniumhq.github.io#1259
Types of changes
Checklist