feat/fix spawn format for SeleniumServer, issue 11405 #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potapovDim
force-pushed
the
feat/spaw-args-format-SeleniumServer
branch
from
7bc842f
to
47876c7
Compare
harsha509
approved these changes
Dec 12, 2022
|
@harsha509 it would be perfect if we can get it published as a patch |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Test failures are not due to changes in this PR! Flaky tests are seen when tests are run with jasmine and not with mocha. Trying to debug more from jasmine-core as am able to reproduce the issue! Merging this PR as of now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align exec(spawn) args order (format) due to breaking changes between selenium standalone 3x and 4x
Description
Add format alignment util for spawn args which will support v3x and v4x selenium stand alone formats
Motivation and Context
Types of changes
Checklist