Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Fix sdist tar package_dir #11416

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

jameshilliard
Copy link
Contributor

We need to set package_dir so that the tar file extracts to the expected directory.

Tar paths currently look like this:

$ tar -tvf selenium-4.7.2.tar.gz 
-rw-r--r--  0 0      0       45052 Dec 31  1999 CHANGES
-rw-r--r--  0 0      0         834 Dec 31  1999 MANIFEST.in
-rw-r--r--  0 0      0        7160 Dec 31  1999 PKG-INFO
-rw-r--r--  0 0      0        6241 Dec 31  1999 README.rst
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium/
-rw-r--r--  0 0      0         811 Dec 31  1999 selenium/__init__.py
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium/common/
-rw-r--r--  0 0      0        3546 Dec 31  1999 selenium/common/__init__.py
-rw-r--r--  0 0      0        8865 Dec 31  1999 selenium/common/exceptions.py
-rw-r--r--  0 0      0           0 Dec 31  1999 selenium/py.typed
-rw-r--r--  0 0      0        1010 Dec 31  1999 selenium/types.py
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium/webdriver/
-rw-r--r--  0 0      0        2415 Dec 31  1999 selenium/webdriver/__init__.py

This adds the correct path prefix so that they look like this:

$ tar -tvf selenium-4.7.2.tar.gz
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium-4.7.2/
-rw-r--r--  0 0      0       45052 Dec 31  1999 selenium-4.7.2/CHANGES
-rw-r--r--  0 0      0         834 Dec 31  1999 selenium-4.7.2/MANIFEST.in
-rw-r--r--  0 0      0        7160 Dec 31  1999 selenium-4.7.2/PKG-INFO
-rw-r--r--  0 0      0        6241 Dec 31  1999 selenium-4.7.2/README.rst
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium-4.7.2/selenium/
-rw-r--r--  0 0      0         811 Dec 31  1999 selenium-4.7.2/selenium/__init__.py
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium-4.7.2/selenium/common/
-rw-r--r--  0 0      0        3546 Dec 31  1999 selenium-4.7.2/selenium/common/__init__.py
-rw-r--r--  0 0      0        8865 Dec 31  1999 selenium-4.7.2/selenium/common/exceptions.py
-rw-r--r--  0 0      0           0 Dec 31  1999 selenium-4.7.2/selenium/py.typed
-rw-r--r--  0 0      0        1010 Dec 31  1999 selenium-4.7.2/selenium/types.py
drwxr-xr-x  0 0      0           0 Dec 31  1999 selenium-4.7.2/selenium/webdriver/
-rw-r--r--  0 0      0        2415 Dec 31  1999 selenium-4.7.2/selenium/webdriver/__init__.py

We need to set package_dir so that the tar file extracts to
the expected directory.
@codecov-commenter
Copy link

Codecov Report

Base: 54.54% // Head: 54.54% // No change to project coverage 👍

Coverage data is based on head (14e6308) compared to base (4f218e0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11416   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          85       85           
  Lines        5627     5627           
  Branches      243      243           
=======================================
  Hits         3069     3069           
  Misses       2315     2315           
  Partials      243      243           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner
Copy link
Member

Thanks for this!

@titusfortner titusfortner merged commit ee136e1 into SeleniumHQ:trunk Dec 13, 2022
@jameshilliard jameshilliard deleted the sdist-pkg-dir branch December 13, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants