[java][cdp] Ensure console events return args as it is #11435

pujagani · 2022-12-16T06:11:33Z

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Ensure console events return args as it is.
Selenium was modifying the args and returning them to the user. That resulted in wrong values, the PR fixes that.

Motivation and Context

See #11377.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

Fixes SeleniumHQ#11377

codecov-commenter · 2022-12-16T06:22:40Z

Codecov Report

Base: 52.83% // Head: 54.54% // Increases project coverage by +1.70% 🎉

Coverage data is based on head (a5080ce) compared to base (3832787).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #11435      +/-   ##
==========================================
+ Coverage   52.83%   54.54%   +1.70%     
==========================================
  Files          82       85       +3     
  Lines        5551     5627      +76     
  Branches      198      243      +45     
==========================================
+ Hits         2933     3069     +136     
+ Misses       2420     2315     -105     
- Partials      198      243      +45

Impacted Files	Coverage Δ
...selenium/webdriver/common/virtual_authenticator.py	`75.00% <0.00%> (-4.04%)`	⬇️
py/selenium/webdriver/support/wait.py	`70.58% <0.00%> (-1.97%)`	⬇️
py/selenium/webdriver/remote/webelement.py	`36.15% <0.00%> (-0.16%)`	⬇️
py/selenium/common/exceptions.py	`100.00% <0.00%> (ø)`
py/selenium/webdriver/common/by.py	`100.00% <0.00%> (ø)`
py/selenium/webdriver/common/log.py	`23.88% <0.00%> (ø)`
py/selenium/webdriver/ie/service.py	`100.00% <0.00%> (ø)`
py/selenium/webdriver/common/keys.py	`100.00% <0.00%> (ø)`
py/selenium/webdriver/common/alert.py	`23.07% <0.00%> (ø)`
py/selenium/webdriver/common/proxy.py	`17.17% <0.00%> (ø)`
... and 47 more