Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] Build static Rust binaries for Selenium Manager (#11400) #11471

Merged
merged 1 commit into from
Dec 28, 2022
Merged

[rust] Build static Rust binaries for Selenium Manager (#11400) #11471

merged 1 commit into from
Dec 28, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR includes some Rusts flags (-C target-feature=+crt-static) for building the Selenium Manager binaries.

Motivation and Context

Static linking will prevent issues like #11400.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia mentioned this pull request Dec 22, 2022
Closed
@bonigarcia bonigarcia merged commit 9635345 into trunk Dec 28, 2022
@bonigarcia bonigarcia deleted the se_mgr_static_linking branch December 28, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonigarcia @diemol