Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Run tests with @baze/jasmine #11486

Merged
merged 3 commits into from
Dec 27, 2022
Merged

[JS] Run tests with @baze/jasmine #11486

merged 3 commits into from
Dec 27, 2022

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 26, 2022

Description

  • JS has multiple test runners configured (@bazel/jasmine, jasmine, mocha). as tests runs with @bazel/jasmine in CI, this PR removes initial jasmine configuration

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509 harsha509 marked this pull request as ready for review December 26, 2022 12:12
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harsha509
Copy link
Member Author

JS Checks Looks good to me!

@harsha509 harsha509 merged commit 4071737 into SeleniumHQ:trunk Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant