Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Execute Rust tests in CI #11541

Merged
merged 3 commits into from
Jan 12, 2023
Merged

[rust] Execute Rust tests in CI #11541

merged 3 commits into from
Jan 12, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR contains a CI workflow to run the Rust tests (i.e., the tests for Selenium Manager) in GitHub Actions.

Motivation and Context

Currently, the Rust tests are not being executed on GitHub Actions. It would be convenient to run these tests each time a new commit with updated on the rust folder.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

.github/workflows/ci-rust.yml Outdated Show resolved Hide resolved
.github/workflows/ci-rust.yml Outdated Show resolved Hide resolved
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diemol
Copy link
Member

diemol commented Jan 12, 2023

One more thing, can you add https://github.com/SeleniumHQ/selenium/blob/trunk/.github/workflows/ci-java.yml#L6 so it can be triggered manually?

@bonigarcia
Copy link
Member Author

Sure, I have just committed another patch for manual trigger.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bonigarcia bonigarcia merged commit b5b25eb into trunk Jan 12, 2023
@bonigarcia bonigarcia deleted the ci_rust branch January 12, 2023 14:47
@titusfortner
Copy link
Member

attn @p0deje for https://github.com/SeleniumHQ/selenium/tree/ci-merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants