-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-1533899181 #11551
issue-1533899181 #11551
Conversation
solve array ClassCastException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test case to verify this?
Codecov ReportBase: 54.66% // Head: 54.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11551 +/- ##
=======================================
Coverage 54.66% 54.66%
=======================================
Files 85 85
Lines 5643 5643
Branches 243 243
=======================================
Hits 3085 3085
Misses 2315 2315
Partials 243 243 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RussiaVk, seems this PR is not compiling?
Hi,reproduce code here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the code to reproduce as a test so we can always check that this does not break? In the meantime I will let the CI run.
As part of the pull request, I meant. If you need help to figure it out, please feel free to reach out to us in the chats available https://www.selenium.dev/support/ |
Add test code for specific type of array
Please check it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please run bazel build grid
and post the final output in a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @RussiaVk!
solve array ClassCastException
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist