Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][bidi] Enable BiDi for Chromium browsers. Extend tests for BiDi supporting browsers. #11626

Merged
merged 25 commits into from
May 30, 2023

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Feb 7, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Enable BiDi for Chromium browsers. Extend tests for BiDi-supporting browsers.

Motivation and Context

https://wpt.fyi/results/webdriver/tests/bidi?label=experimental&label=master&aligned&view=subtest show that BiDi is supported in the recent chrome versions. The changes enable BiDi support for Chromium based browsers. The PR is draft PR mainly to see what APIs work/exist in the given version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (254e534) 54.83% compared to head (4170ebb) 54.83%.

❗ Current head 4170ebb differs from pull request most recent head 2de324b. Consider uploading reports for the commit 2de324b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11626   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files          86       86           
  Lines        5730     5730           
  Branches      233      233           
=======================================
  Hits         3142     3142           
  Misses       2355     2355           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pujagani pujagani marked this pull request as ready for review February 22, 2023 09:18
@diemol diemol linked an issue May 23, 2023 that may be closed by this pull request
@diemol diemol merged commit 2beaa59 into SeleniumHQ:trunk May 30, 2023
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Add HasBiDi to Chromium Driver class
4 participants