Remove "shadow_root" assertion in Python bindings for Firefox #11821
Conversation
whimboo
changed the title
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11821 +/- ##
==========================================
- Coverage 54.85% 54.83% -0.02%
==========================================
Files 85 85
Lines 5695 5693 -2
Branches 230 230
==========================================
- Hits 3124 3122 -2
Misses 2341 2341
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The "Get Element ShadowRoot" command has been implemented in Firefox 96 (a year ago) and it should no longer cause an assertion.
whimboo
force-pushed
the
firefox_shadow_root
branch
from
e663ed9
to
d089016
Compare
|
This PR is ready for review. Thanks! |
|
CC'ing @patrickangle and @gsnedders given that the same assertion still exists for Safari and as it looks like there might have been some ongoing work here on experimental. |
actually shipped in Safari 16.4 on Tuesday: https://wpt.fyi/results/webdriver/tests/get_element_shadow_root/get.py?run_id=5118756219518976&run_id=6320265787604992&run_id=6292883592708096 |
…umHQ#11821) Remove "shadow_root" assertion for Firefox. The "Get Element ShadowRoot" command has been implemented in Firefox 96 (a year ago) and it should no longer cause an assertion. Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
The "Get Element ShadowRoot" command has been implemented in Firefox 96 (a year ago) and it should no longer cause an assertion.