[Rust] Refactors #11832
Merged
[Rust] Refactors #11832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bonigarcia
reviewed
Apr 2, 2023
There was a problem hiding this comment.
Hi @dev-ardi. Are you using cargo fmt to format the code in this PR?
|
Buenos días @bonigarcia, Yes I am, that's the reason behind the commit ac551af |
|
We also use cargo fmt, thanks! |
bonigarcia
approved these changes
Apr 4, 2023
|
@dev-ardi could you please sign the CLA and resolve the conflicts? |
|
Done |
|
I have no idea how to merge these locally😞 |
|
You can use the GitHub UI for that...
|
|
@dev-ardi hey, we have numerous chat services all interconnected if you're interested. https://www.selenium.dev/support/ It might mean you get quicker answers as people might not always be watching GitHub notifications. We would love for you to join us and come hang out |
yashcho
pushed a commit
to yashcho/selenium
that referenced
this pull request
Apr 7, 2023
* Refactor so that it's more concise * cargo fmt * I found it too verbose * String interpolation * Since the error message is the same now put it in the chain. * Added never return type so I can remove the calls to exit() --------- Co-authored-by: ogonzalez <ogonzalez@iconmm.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General refactors in the selenium manager
Motivation and Context
I was going to add a new functionality and found some code that could get updated.
Checklist
Changes
if let Errsyntax if this change is not accepted