[js] fix: return statement in submit()

[TamsilAmani]

Description

The value evaluated by the submit() was not being returned.

Motivation and Context

Help developers who use selenium to get correct result.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[harsha509]

Makes sense!

Thank you @TamsilAmani !

[harsha509]

Thank you @TamsilAmani !

[titusfortner]

What result are we expecting from submit? It's an action on the browser, so the return should be null

Checked the code again after @titusfortner comment, looks like it is only returning null. Do you have any use case tamsil ?

[swrdfish]

@titusfortner @harsha509
Thank you for looking into this.

I stumbled upon this bug while working on Nightwatch. The problem is that .submit() is supposed to return a promise, which can be used to wait for the command to complete. Without the promise we cannot ensure that subsequent actions behave deterministically. It is not the value we are interested in but the promise to let us know when the command has finished.