Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Use ChangeType method to convert any object to boolean in WebElement propoerties #11913

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[dotnet] Use ChangeType method to convert any object to boolean in WebElement propoerties #11913

merged 1 commit into from
Apr 19, 2023

Conversation

nvborisenko
Copy link
Member

This approach brings us a possibility to track what exactly we try to convert.

Description

var a = (object)"true";
var b = (bool)a;

It always throws InvalidCastException.

There is safer method:

var a = (object)"true";
var b = (bool)Convert.ChageType(a, typeof(bool));

Even if input is not formatted well to be boolean, then we will get more clear exception:

System.FormatException: String 'false 66' was not recognized as a valid Boolean.

where false 66 is incorrect input.

Motivation and Context

Just to get more clear understanding what is going wrong, and highlight a value returned from server side.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nvborisenko!

@diemol diemol added this to the 4.9 milestone Apr 19, 2023
@diemol diemol merged commit 0ae495c into SeleniumHQ:trunk Apr 19, 2023
13 checks passed
@nvborisenko nvborisenko deleted the safe-conversion branch April 19, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants