Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] Selenium Manager detects ARM architecture on Windows #11939

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[rust] Selenium Manager detects ARM architecture on Windows #11939

merged 1 commit into from
Apr 25, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR enables the detection of ARM architecture in Windows machines.

Motivation and Context

Part of #11357.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@bonigarcia bonigarcia merged commit 98d3e26 into trunk Apr 25, 2023
14 of 15 checks passed
@bonigarcia bonigarcia deleted the se_mgr_winarm branch April 25, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
C-rust
Projects
Selenium Manager
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonigarcia @diemol