Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] add more logging to Selenium Manager #11959

Merged
merged 3 commits into from
May 2, 2023
Merged

[java] add more logging to Selenium Manager #11959

merged 3 commits into from
May 2, 2023

Conversation

titusfortner
Copy link
Member

Description

  • Changes log name to log which we want to make the standard in the rest of the project (future PR)
  • Add INFO that about to use Selenium Manager
  • Send --verbose to Selenium Manager if logging set to FINE or higher
  • Add FINE for:
    • Command executed
    • Driver Path being used
    • Any DEBUG lines of log

Motivation and Context

We need to be able to get more details about what problems users are having
Also (at least while in Beta) we want users to know that Selenium Manager is being used.
We may want to change that from INFO to FINE after beta?

Ideally we have a section on Selenium Manager in our documentation that we can point to for explaining what it is doing and how to get more logging info, etc. But that's a future PR.

@titusfortner
Copy link
Member Author

Ah found the issue for this PR - #11642

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

java/src/org/openqa/selenium/manager/SeleniumManager.java Outdated Show resolved Hide resolved
@diemol diemol merged commit 8921182 into trunk May 2, 2023
52 of 55 checks passed
@diemol diemol deleted the sm_logging branch May 2, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants