Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] simplified some control flows logic and removed unused imports #11974

Merged
merged 14 commits into from
May 17, 2023
Merged

[java] simplified some control flows logic and removed unused imports #11974

merged 14 commits into from
May 17, 2023

Conversation

iampopovich
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

changes are provided to increase code readability
removing unused imports provided to increase code clearness and decrease build time also

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de7acb9) 54.85% compared to head (60af42e) 54.85%.

❗ Current head 60af42e differs from pull request most recent head 606ddfe. Consider uploading reports for the commit 606ddfe to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11974   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files          86       86           
  Lines        5728     5728           
  Branches      233      233           
=======================================
  Hits         3142     3142           
  Misses       2353     2353           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I left a small comment.

java/src/org/openqa/selenium/remote/ErrorHandler.java Outdated Show resolved Hide resolved
@diemol diemol merged commit 89f1f08 into SeleniumHQ:trunk May 17, 2023
49 of 54 checks passed
@iampopovich iampopovich deleted the java-wip-branch branch June 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants