-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] simplified some control flows logic and removed unused imports #11974
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11974 +/- ##
=======================================
Coverage 54.85% 54.85%
=======================================
Files 86 86
Lines 5728 5728
Branches 233 233
=======================================
Hits 3142 3142
Misses 2353 2353
Partials 233 233 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. I left a small comment.
java/src/org/openqa/selenium/grid/commands/CompletionCommand.java
Outdated
Show resolved
Hide resolved
fix imports after conflict
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
changes are provided to increase code readability
removing unused imports provided to increase code clearness and decrease build time also
Motivation and Context
Types of changes
Checklist