Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] update logging to match other bindings #11990

Merged
merged 4 commits into from
May 4, 2023
Merged

[py] update logging to match other bindings #11990

merged 4 commits into from
May 4, 2023

Conversation

titusfortner
Copy link
Member

Description

Log more things for Selenium Manager
Removes a browser check that shouldn't be necessary. We're using options instances, but if a browserName is set that isn't recognized, SM will give the appropriate error.

Motivation and Context

Match what is being done in other languages
Need to be able to see more details for Selenium Manager issues

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.04 ⚠️

Comparison is base (66e51be) 54.89% compared to head (535b2fc) 54.85%.

❗ Current head 535b2fc differs from pull request most recent head cc2b37a. Consider uploading reports for the commit cc2b37a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #11990      +/-   ##
==========================================
- Coverage   54.89%   54.85%   -0.04%     
==========================================
  Files          86       86              
  Lines        5733     5728       -5     
  Branches      233      233              
==========================================
- Hits         3147     3142       -5     
  Misses       2353     2353              
  Partials      233      233              
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 67.24% <42.85%> (-2.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 59fa77c into trunk May 4, 2023
16 checks passed
@diemol diemol deleted the py_sm_log branch May 4, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants