Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of urllib3 #11993

Merged
merged 1 commit into from
May 5, 2023

Conversation

mdmintz
Copy link
Contributor

@mdmintz mdmintz commented May 4, 2023

Description

Add support for urllib3 2

Motivation and Context

This resolves #11988

Types of changes

  • Dependency update

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (000cb08) 54.85% compared to head (ac4b7ee) 54.85%.

❗ Current head ac4b7ee differs from pull request most recent head 140e271. Consider uploading reports for the commit 140e271 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11993   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files          86       86           
  Lines        5728     5728           
  Branches      233      233           
=======================================
  Hits         3142     3142           
  Misses       2353     2353           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AutomatedTester AutomatedTester merged commit 19a4582 into SeleniumHQ:trunk May 5, 2023
15 checks passed
@mdmintz mdmintz deleted the urllib3-upgrade branch May 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: The latest version of Selenium does not support the latest version of urllib3
3 participants