Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] make all logging variable names consistent #12007

Merged
merged 3 commits into from
May 17, 2023
Merged

[java] make all logging variable names consistent #12007

merged 3 commits into from
May 17, 2023

Conversation

titusfortner
Copy link
Member

Description

All logging uses:

private static final Logger LOG

Motivation and Context

Make convention the same throughout the codebase

@titusfortner titusfortner requested a review from diemol May 8, 2023 16:01
# Conflicts:
#	java/src/org/openqa/selenium/devtools/DevTools.java
#	java/src/org/openqa/selenium/net/HostIdentifier.java
#	java/src/org/openqa/selenium/net/UrlChecker.java
#	java/src/org/openqa/selenium/remote/AddHasAuthentication.java
#	java/src/org/openqa/selenium/remote/ErrorCodes.java
#	java/src/org/openqa/selenium/remote/RemoteLogs.java
#	java/src/org/openqa/selenium/remote/RemoteWebDriver.java
#	java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java
#	java/src/org/openqa/selenium/remote/http/netty/NettyWebSocket.java
#	java/src/org/openqa/selenium/remote/server/handler/FindElement.java
#	java/src/org/openqa/selenium/support/events/EventFiringDecorator.java
#	java/test/org/openqa/selenium/remote/server/rest/ResultConfigTest.java
#	java/test/org/openqa/selenium/testing/drivers/Browser.java
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (da0dcef) 54.85% compared to head (a34e5bc) 54.85%.

❗ Current head a34e5bc differs from pull request most recent head 7f5eeb7. Consider uploading reports for the commit 7f5eeb7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12007   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files          86       86           
  Lines        5728     5728           
  Branches      233      233           
=======================================
  Hits         3142     3142           
  Misses       2353     2353           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 971a727 into trunk May 17, 2023
49 of 55 checks passed
@diemol diemol deleted the log_rename branch May 17, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants