Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Fix building errors of the solution in VS via isolating output path per project #12063

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

nvborisenko
Copy link
Member

Description

This PR fixes errors like

image

Motivation and Context

WebDriver.NET solution consists of many projects, and each of them has one shared folder to built into it (/build/dotnet/cli). When we build solution, there is a chance to get inconsistent build process like:

  • files are always overridden
  • especially when building projects concurrently

Microsoft paid an attention on this situation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nvborisenko!

@diemol diemol merged commit 7cd20cf into SeleniumHQ:trunk May 19, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants