[dotnet] Implementation of event wrapped shadow root element #12073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand the complexity of setting the environment when space is limited. I can help to test the PR on my local Windows machine. In addition, I am checking GitHub Codespaces to see if it is possible to have a cloud environment for Windows. |
|
I postponed OS re-installation. In scope of this PR I need to create new unit tests to cover functionality. This is why PR is draft. I quickly looked through code, and it promising operational. In any case unit tests are required here. |
nvborisenko
changed the title
|
Created new unit tests, this PR is ready for review. |
diemol
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Thank you, @nvborisenko!
Failures are not related to this PR, we need to check them apart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raises events for web elements under shadow root.
Motivation and Context
Fixes #12049
Types of changes
Checklist
Note:
This is draft. I am out of disk space even to build solution. Bazel took 10GBs, Git repo 3GB (excluding preinstalled dependencies), and this is just to build 30MB nuget package. I will migrate from 256GB ssd to 1TB ssd, and in any case I will never install selenium dev dependencies on my system drive, shortly saying selenium dev environment will be isolated in VM.