-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb][bidi] network module events #12228
base: trunk
Are you sure you want to change the base?
Conversation
rb/spec/integration/selenium/webdriver/bidi/network_inspector_spec.rb
Outdated
Show resolved
Hide resolved
08f6234
to
b63c1dc
Compare
@p0deje @titusfortner In another module (Script) I have wrapped the response into custom-defined classes which I need to change as per your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great. In regards to wrapping request/response, I think we can iterate later and generalize rb/lib/selenium/webdriver/devtools/request.rb and rb/lib/selenium/webdriver/devtools/response.rb later.
b63c1dc
to
8a9a1f0
Compare
8a9a1f0
to
211fd8a
Compare
Description
Add network module events and types
Motivation and Context
Implement network module events and types as described in https://w3c.github.io/webdriver-bidi/#module-network
Types of changes
Checklist