Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] let users pass service args to IE driver #12272

Merged
merged 2 commits into from Jun 28, 2023
Merged

[py] let users pass service args to IE driver #12272

merged 2 commits into from Jun 28, 2023

Conversation

titusfortner
Copy link
Member

Description

Match other browsers

Motivation and Context

Currently no way to set the extract path (I know, right?)

    service = webdriver.IeService(service_args=["–extract-path="+temp_dir])

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ed2d9f) 57.22% compared to head (146c268) 57.23%.

❗ Current head 146c268 differs from pull request most recent head c6c02d2. Consider uploading reports for the commit c6c02d2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12272   +/-   ##
=======================================
  Coverage   57.22%   57.23%           
=======================================
  Files          86       86           
  Lines        5480     5481    +1     
  Branches      226      226           
=======================================
+ Hits         3136     3137    +1     
  Misses       2118     2118           
  Partials      226      226           
Impacted Files Coverage Δ
py/selenium/webdriver/ie/service.py 90.32% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 2532076 into trunk Jun 28, 2023
1 check passed
@diemol diemol deleted the py_ie branch June 28, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants