Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] implement downloading grid with Selenium Manager #12299

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jul 2, 2023

Status

I'm moving this to draft for us to discuss whether we want to implement this in other bindings and synchronize the versions.

Also, play-by-play is here - https://www.youtube.com/watch?v=0rL6Dtoo8As

Description

  • Created method for downloading grid in Selenium Manager
  • Executes by default with old method as backup

Motivation and Context

  • Remove network command executions from Selenium code and let the binary manage it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@titusfortner titusfortner marked this pull request as draft July 2, 2023 21:17
Copy link
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selenium/server.rb always seemed to much for me - I like SM approach.

@titusfortner
Copy link
Member Author

I think ruby is the only one that implemented it in the first place, though. It's a great feature, and would be nice to have in all the bindings.

But yes, this is exactly the kind of overhead and duplication that Selenium manager is great at removing. (thanks again @bonigarcia)

@diemol
Copy link
Member

diemol commented Apr 30, 2024

I believe we still want to implement this.

@diemol diemol reopened this Apr 30, 2024
@github-actions github-actions bot removed the Stale label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants