Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Client config class for http client values #12369

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

titusfortner
Copy link
Member

Status

Description

  • Creates a Client config class like Java has to store configuration values related to Http Client
  • Have users set "keep alive" in client config instead of in Options since it is not related to capabilities
  • Have users set "ignore proxy" in client config instead of webdriver directly; this is done by creating a proxy of type "Direct" instead of default "System"

Browser subclasses for RemoteConnection and WebDriver set deprecated value defaults to None
Remote superclass for those throw the deprecation warning if they are not None so subclasses still need to send them.

@isaulv told me to be careful creating objects in constructor parameters, so I'm just using None and setting defaults in first line.

Also, I separated out the code for whether to use a proxy into a new private method

Motivation and Context

This is to match what Java is doing and better organize the constructor parameters
also sets us up to make more values configurable in a future PR.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 83.82979% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 58.20%. Comparing base (276240d) to head (9fbe979).
Report is 1636 commits behind head on trunk.

❗ Current head 9fbe979 differs from pull request most recent head 8fc6601. Consider uploading reports for the commit 8fc6601 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/remote/remote_connection.py 69.64% 17 Missing ⚠️
py/selenium/webdriver/ie/webdriver.py 62.50% 6 Missing ⚠️
py/selenium/webdriver/remote/webdriver.py 76.19% 4 Missing and 1 partial ⚠️
py/selenium/webdriver/chromium/webdriver.py 86.20% 0 Missing and 4 partials ⚠️
py/selenium/webdriver/firefox/remote_connection.py 71.42% 2 Missing ⚠️
py/selenium/webdriver/safari/webdriver.py 83.33% 2 Missing ⚠️
py/selenium/webdriver/firefox/webdriver.py 91.66% 1 Missing ⚠️
py/selenium/webdriver/remote/client_config.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12369      +/-   ##
==========================================
+ Coverage   57.28%   58.20%   +0.92%     
==========================================
  Files          86       89       +3     
  Lines        5333     5470     +137     
  Branches      193      201       +8     
==========================================
+ Hits         3055     3184     +129     
  Misses       2085     2085              
- Partials      193      201       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the Stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants