Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Display warning message due to driver in PATH only if major is different #12460

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR changes the condition to display a warning due to a potentially incompatible driver found in the PATH. With this change, the warning message is only displayed when the major version of the found driver (e.g., 113) is different to the recommended major driver version (e.g., 115).

Motivation and Context

Improvement to Selenium Manager released with Selenium 4.11.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2ee529e) 57.28% compared to head (ab9414f) 57.28%.
Report is 3 commits behind head on trunk.

❗ Current head ab9414f differs from pull request most recent head 5f6c133. Consider uploading reports for the commit 5f6c133 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12460   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5338     5338           
  Branches      198      198           
=======================================
  Hits         3058     3058           
  Misses       2082     2082           
  Partials      198      198           
Files Changed Coverage Δ
py/selenium/__init__.py 100.00% <100.00%> (ø)
py/selenium/webdriver/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonigarcia bonigarcia merged commit 8f6cc22 into trunk Aug 1, 2023
53 of 56 checks passed
@bonigarcia bonigarcia deleted the se_mgr_warn_major branch August 1, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants