Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] moved safari options to descriptor class #12553

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

sandeepsuryaprasad
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Moved all Safari options to descriptor class

Motivation and Context

  • Refactored safari options by moving to descriptor class
  • Also, I have fixed linting issue in remote/remote_connection.py. (this was broken in PR 11957)

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 15.78% and project coverage change: -0.28% ⚠️

Comparison is base (d124c60) 57.26% compared to head (2afc19c) 56.98%.
Report is 11 commits behind head on trunk.

❗ Current head 2afc19c differs from pull request most recent head 4707e65. Consider uploading reports for the commit 4707e65 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12553      +/-   ##
==========================================
- Coverage   57.26%   56.98%   -0.28%     
==========================================
  Files          86       86              
  Lines        5335     5331       -4     
  Branches      198      198              
==========================================
- Hits         3055     3038      -17     
- Misses       2082     2095      +13     
  Partials      198      198              
Files Changed Coverage Δ
py/selenium/webdriver/remote/remote_connection.py 54.58% <ø> (ø)
py/selenium/webdriver/safari/options.py 38.46% <15.78%> (-51.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit bc8ff4f into SeleniumHQ:trunk Aug 16, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants