Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'getArray' method for array values #12703

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

sbabcoc
Copy link
Contributor

@sbabcoc sbabcoc commented Sep 7, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR adds a new getArray method to the Config interface.

Motivation and Context

Configuration objects may contain arrays of configuration values (e.g. - multiple driver-configuration entries for a Grid node). Currently, the Config interface returns these as a flat array of settings, and the process of splitting this array into its individual entries is left to the client. This is a tedious task that requires the client implementation to walk through the flat list searching for delimiters. The count of entries in the array cannot be determined without parsing the entire flat list.

The new getArray method splits the flat list of settings into individual configuration entries.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbabcoc sbabcoc force-pushed the pr/add-getArray-method branch 2 times, most recently from 0f2828c to 4f0479e Compare September 7, 2023 18:22
@sbabcoc
Copy link
Contributor Author

sbabcoc commented Sep 7, 2023

Resolves #12357

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (d1a5912) 57.02% compared to head (652b2d8) 57.02%.
Report is 1 commits behind head on trunk.

❗ Current head 652b2d8 differs from pull request most recent head a7bc35a. Consider uploading reports for the commit a7bc35a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12703   +/-   ##
=======================================
  Coverage   57.02%   57.02%           
=======================================
  Files          86       86           
  Lines        5322     5322           
  Branches      192      192           
=======================================
  Hits         3035     3035           
  Misses       2095     2095           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diemol diemol merged commit 8add578 into SeleniumHQ:trunk Sep 8, 2023
38 of 53 checks passed
@sbabcoc sbabcoc deleted the pr/add-getArray-method branch September 9, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants