Add RBS files to Ruby #12844

aguspe · 2023-09-30T13:12:42Z

Description

I created RBS files for the following classes and modules so far:

AbstractEventListener
ActionBuilder
Atoms
Bridge
Chrome
Chromium::Features
Driver
Element
Edge
Edge::Features
Firefox
Firefox::Features
HasCasting
HasLaunching
InputDevice
Interaction
Logger
KeyActions
KeyInput
Manager
Navigation
PointerActions
PointerInput
Remote
Response
Safari
Safari::Features
ScrollOrigin
SearchContext
ShadowRoot
TakesScreenshot
TargetLocator
Timeouts
TypingInteracton
Version
VirtualAuthenticator
Webdriver
WheelInput

Also, I added support for steep: https://github.com/soutaro/steep

You can run the following to do the type check:
steep check

This PR is the first one of multiple PRs adding support for RBS and type check to the ruby library.

Motivation and Context

Ruby Selenium does a lot of meta-programming which makes it more difficult to use with an IDE like RubyMine.
Adding rbs files, *should make this much easier.

More information and further discussion can be found here: #10943

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

CLAassistant · 2023-09-30T13:12:47Z

All committers have signed the CLA.

titusfortner · 2023-10-08T20:49:47Z

Hey, how is it going with this? We don't have to do it all in one go if you don't want; it might be easier to ensure it is all rebased properly. Just mark it as out of draft when you're ready for us to pull something. I'm not familiar yet with these files, but I'm looking forward to using them. Thanks.

codecov-commenter · 2023-10-08T21:24:02Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1fa0af4) 56.51% compared to head (5b11216) 56.51%.
Report is 84 commits behind head on trunk.

❗ Current head 5b11216 differs from pull request most recent head 820a474. Consider uploading reports for the commit 820a474 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #12844   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187

Files	Coverage Δ
py/selenium/__init__.py	`100.00% <100.00%> (ø)`
py/selenium/webdriver/common/service.py	`88.70% <100.00%> (ø)`
py/selenium/webdriver/common/selenium_manager.py	`57.89% <75.00%> (ø)`
py/selenium/webdriver/common/bidi/cdp.py	`22.64% <0.00%> (ø)`
py/selenium/webdriver/remote/remote_connection.py	`53.87% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aguspe · 2023-10-16T15:43:24Z

Hey, how is it going with this? We don't have to do it all in one go if you don't want to; it might be easier to ensure it is all rebased properly. Just mark it as out of draft when you're ready for us to pull something. I'm not familiar yet with these files, but I'm looking forward to using them. Thanks.

Hey, it's slowly but surely going, it would definitely be easier to review and test to make smaller PRs.
What I can do is finish with the last files that I'm missing
(Every time I want to add support for a type based on a class I need to create the RBS file for that class, so I'm missing a couple)

I can wrap it up this weekend and prepare it for review and merge.

For now, I created small commits that I will squash afterward just to make the development on the draft easy to follow.

titusfortner · 2023-10-16T16:01:06Z

what library is needed to use it?
I think we want to add a dev dependency for our tests and make sure the files are working?
Like, we don't change the test code, it is just going to throw an error if the typing is wrong and the user is using that library?

aguspe · 2023-10-16T21:16:53Z

what library is needed to use it? I think we want to add a dev dependency for our tests and make sure the files are working? Like, we don't change the test code, it is just going to throw an error if the typing is wrong and the user is using that library?

I think steep is the best option, I added a local steep file that I did not commit yet since I'm still testing the config.
Here is the Github to Steep: https://github.com/soutaro/steep, it's well-maintained and it's really simple to use.

I will add to the description of this PR and update the docs on how to use steep, but pretty much once that you have the config you just need to run 'steep check' and that's it

titusfortner · 2023-10-16T21:32:38Z

So we can put it in the CI to run the check similar to what we do with rubocop and it will verify our test code?

aguspe · 2023-10-17T05:32:58Z

So we can put it in the CI to run the check similar to what we do with Rubocop and it will verify our test code?

Exactly, we can add it, the same as a Rubocop check, I can add it as part of the rb actions flows (https://github.com/SeleniumHQ/selenium/blob/trunk/.github/workflows/ci-ruby.yml).

However, I never worked directly on Bazel but I was just looking into that, I could modify the lint test to make it run with steep and validate the types.

Also sorry for the delayed replies, I'm on CET time so I might always be 7 to 8 hours delayed haha.

titusfortner · 2023-10-17T11:43:53Z

No worries, we can get the bazel pieces sorted later if needed, and this project is very geographically distributed, so communication delays are the norm.

aguspe · 2023-10-22T16:16:19Z

@titusfortner it's ready for review now, I added RBS and steep as dev dependencies and I would like to update the documentation, where would you suggest I update the documentation for other devs regarding type checking?

p0deje

Thank you for submitting this massive PR. I am not familiar with RBS/Steep, so maybe you can clarify few points for me?

Should sig be shipped as part of the gem or pushed to https://github.com/ruby/gem_rbs_collection/?
I see plenty of untyped in definitions, should those be replaced with something more strict at some point?
Should be run type check for spec/ folder as well?
There are some code duplications across RB/RBS files (e.g. URLs in EDGE_COMMANDS or DEFAULT_SECURE_SSL). Is this expected?
There are comments in RBS, but they don't seem to provide any value and look like copies from RB files.
How do we maintain rb/rbs_collection.lock.yaml?

aguspe · 2023-10-27T19:08:53Z

Thank you for submitting this massive PR. I am not familiar with RBS/Steep, so maybe you can clarify few points for me?

Should sig be shipped as part of the gem or pushed to https://github.com/ruby/gem_rbs_collection/?

I see plenty of untyped in definitions, should those be replaced with something more strict at some point?

Should be run type check for spec/ folder as well?

There are some code duplications across RB/RBS files (e.g. URLs in EDGE_COMMANDS or DEFAULT_SECURE_SSL). Is this expected?

There are comments in RBS, but they don't seem to provide any value and look like copies from RB files.

How do we maintain rb/rbs_collection.lock.yaml?

Hello, sorry for the delay, it's busy week haha

Great question:

So for example in https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md the recommendation is to ship the sig folder as part of the gem if you are the owner of it

Several of the untyped definitions as the ones in WheelInput will be added support, but I think the best approach would be incremental

If I wanted RBS to recognize a class or a module I had to create the file for that class or module to finish the RBS work in that, and it kept expanding more and more ( I could also do it in this PR, it will just take longer and it will probably get bigger)

Yes and we should, we need to add spec as a target on the steep configuration file, but I think it should be outside of this PR
No, I need to fix those duplications, thank you for spotting that :)
I can delete those comments, what I did was use the autogenerate option in ruby mine for RBS files and then modified the templates, and I thought that maybe even though duplicates we might still want the comments
When the Gemfile.lock file is updated we can run rbs collection install to update the rbs_collection.lock.yaml. The same if we update the rbs_collection.yaml

For more info: https://github.com/ruby/rbs/blob/master/docs/collection.md#how-it-works

So @p0deje during the weekend I will be updating point 4 & 5, and I would suggest to do the rest of the support as support for the spec folder and expanding the types in other PRs to limit the size and make it easier to review

aguspe · 2023-10-29T18:53:04Z

@p0deje It's ready for a re-review now

p0deje

I think it's a great start, we'd need to integrate it into specs/Bazel/CI at some point, but I agree it should be done in separate PRs.

…argetLocator

…ion and window

…y actions, pointer actions, scroll origin

…al_authenticator

…ing and has_launching.rbs

titusfortner · 2023-11-06T20:49:21Z

wow, steep really pulls in all the things, doesn't it?

@p0deje where is bazel supposed to be pulling this from?

Bundler::GemNotFound: Could not find ffi-1.16.3 in any of the sources

p0deje · 2023-11-06T20:54:44Z

@titusfortner It should be pulling from the internet, I wonder if our Gemfile.lock just needs to be properly updated.

titusfortner · 2023-11-06T21:00:25Z

Hmm, @aguspe what is your local OS?

Let me pull down a version of jruby and see what happens. 😁

titusfortner · 2023-11-06T21:10:28Z

Ok, I can reproduce this locally on my mac when I:

rbenv local jruby-9.4.3.0
bundle update
bazel test //rb/spec/unit/...

I get:

/private/var/tmp/_bazel_titusfortner/91f41ba347a35b04e5d76e05512d7e6d/external/rules_ruby_dist/dist/lib/ruby/3.0.0/bundler/definition.rb:480:in `materialize': Could not find rack-2.2.8, rake-13.1.0, rubocop-1.57.2, rubocop-performance-1.19.1, rubocop-rspec-2.25.0, webmock-3.19.1, rexml-3.2.6, rspec-mocks-3.12.6, parser-3.2.2.4, regexp_parser-2.8.2, rubocop-ast-1.30.0, unicode-display_width-2.5.0, rubocop-capybara-2.19.0, rubocop-factory_bot-2.24.0, addressable-2.8.5, irb-1.8.3, reline-0.3.9, racc-1.7.3, public_suffix-5.0.3, rdoc-6.6.0, psych-5.1.1.1, stringio-3.0.8 in any of the sources (Bundler::GemNotFound)

when I run it using RubyMine, everything is fine...

aguspe · 2023-11-16T22:30:55Z

Hmm, @aguspe what is your local OS?

Let me pull down a version of Jruby and see what happens. 😁

My OS is Sonoma 14.0 and I'm using a mac M1,

So I have been doing some research and testing it locally
(I had some issues the last couple of days with rbenv so I had to uninstall and re-install several times)

I can reproduce the same issue with jruby-9.4.3.0 & jruby-9.4.4.0

And even though I tried to force the installation of different versions of FFI, I still get

'Bundler::GemNotFound: Could not find ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java, ffi-1.16.0-java in locally installed gems'

So I'm trying to debug this

titusfortner · 2023-11-17T15:00:28Z

(I had some issues the last couple of days with rbenv so I had to uninstall and re-install several times)

I've been there. ☹️

@p0deje any ideas? Is there a way to just skip this for JRuby? 😁

aguspe · 2023-11-17T20:25:03Z

(I had some issues the last couple of days with rbenv so I had to uninstall and re-install several times)

I've been there. ☹️

@p0deje any ideas? Is there a way to just skip this for JRuby? 😁

So if we want to skip it for JRuby and option is to add this on selenium-webdriver.gemspec, as on the last commit:

s.add_development_dependency 'steep', ['~> 1.5'] unless RUBY_PLATFORM == 'java'

I tested this and it works for Jruby and the tests execute well locally at least

p0deje · 2023-11-17T20:28:50Z

Do we need to include it in gemspec at all? We could use it like that in Gemfile:

gem 'rbs', '~> 3.2', require: false, platforms: %i[mri mingw x64_mingw]
gem 'steep', '~> 1.5', require: false, platforms: %i[mri mingw x64_mingw]

This would allow installing it in MRI on Linux/Mac/Windows ignore both JRuby and TruffleRuby

p0deje · 2023-11-17T20:34:38Z

Here is the full patch that makes this work on MRI and JRuby:

diff --git a/rb/Gemfile b/rb/Gemfile
index 9710e18d99..7b58c4e54f 100644
--- a/rb/Gemfile
+++ b/rb/Gemfile
@@ -6,3 +6,5 @@ Dir["#{__dir__}/*.gemspec"].each do |spec|
 end
 
 gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw]
+gem 'rbs', '~> 3.2', require: false, platforms: %i[mri mingw x64_mingw]
+gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw]
diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock
index 5c72bfe7f7..bd8604143b 100644
--- a/rb/Gemfile.lock
+++ b/rb/Gemfile.lock
@@ -11,7 +11,8 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.1)
+    abbrev (0.1.1)
+    activesupport (7.1.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -24,41 +25,44 @@ GEM
     addressable (2.8.4)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
-    base64 (0.1.1)
+    base64 (0.2.0)
     bigdecimal (3.1.4)
-    bigdecimal (3.1.4-java)
     concurrent-ruby (1.2.2)
     connection_pool (2.4.1)
     crack (0.4.5)
       rexml
-    csv (3.2.7)
+    csv (3.2.8)
     debug (1.8.0)
       irb (>= 1.5.0)
       reline (>= 0.3.1)
     diff-lcs (1.5.0)
-    drb (2.1.1)
+    drb (2.2.0)
       ruby2_keywords
     ffi (1.16.3)
-    fileutils (1.7.1)
+    ffi (1.16.3-x64-mingw32)
+    fileutils (1.7.2)
     hashdiff (1.0.1)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     io-console (0.6.0)
-    irb (1.7.0)
-      reline (>= 0.3.0)
+    irb (1.9.0)
+      rdoc
+      reline (>= 0.3.8)
     json (2.6.3)
     json (2.6.3-java)
     language_server-protocol (3.17.0.3)
     listen (3.8.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.5.3)
+    logger (1.6.0)
     minitest (5.20.0)
-    mutex_m (0.1.2)
+    mutex_m (0.2.0)
     parallel (1.23.0)
     parser (3.2.2.3)
       ast (~> 2.4.1)
       racc
+    psych (5.1.1.1)
+      stringio
     public_suffix (5.0.1)
     racc (1.7.1)
     racc (1.7.1-java)
@@ -68,9 +72,12 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rbs (3.2.2)
+    rbs (3.3.0)
+      abbrev
+    rdoc (6.6.0)
+      psych (>= 4.0.0)
     regexp_parser (2.8.1)
-    reline (0.3.5)
+    reline (0.4.0)
       io-console (~> 0.5)
     rexml (3.2.5)
     rspec (3.12.0)
@@ -113,7 +120,7 @@ GEM
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
-    securerandom (0.2.2)
+    securerandom (0.3.0)
     steep (1.5.3)
       activesupport (>= 5.1)
       concurrent-ruby (>= 1.1.10)
@@ -129,8 +136,8 @@ GEM
       securerandom (>= 0.1)
       strscan (>= 1.0.0)
       terminal-table (>= 2, < 4)
+    stringio (3.0.9)
     strscan (3.0.7)
-    strscan (3.0.7-java)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     tzinfo (2.0.6)
@@ -147,6 +154,8 @@ GEM
 PLATFORMS
   java
   ruby
+  universal-java-1.8
+  universal-java-17
   universal-java-18
   x64-mingw32
 
@@ -154,14 +163,14 @@ DEPENDENCIES
   debug (~> 1.7)
   rack (~> 2.0)
   rake (~> 13.0)
-  rbs (~> 3.2.0)
+  rbs (~> 3.2)
   rspec (~> 3.0)
   rubocop (~> 1.42)
   rubocop-performance (~> 1.15)
   rubocop-rspec (~> 2.16)
   selenium-devtools!
   selenium-webdriver!
-  steep (~> 1.5)
+  steep (~> 1.5.0)
   webmock (~> 3.5)
   webrick (~> 1.7)
   yard (~> 0.9.11)
diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec
index 42254af43d..35349a72a9 100644
--- a/rb/selenium-webdriver.gemspec
+++ b/rb/selenium-webdriver.gemspec
@@ -62,12 +62,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'webmock', ['~> 3.5']
   s.add_development_dependency 'webrick', ['~> 1.7']
   s.add_development_dependency 'yard', ['~> 0.9.11']
-
-  if RUBY_PLATFORM == 'java'
-    s.add_development_dependency 'rbs', ['1.2.0']
-    s.add_development_dependency 'steep', ['0.46.0']
-  else
-    s.add_development_dependency 'rbs', ['~> 3.2.0']
-    s.add_development_dependency 'steep', ['~> 1.5']
-  end
 end

@aguspe I can merge your PR and commit this on top if you believe it's mergeable.

p0deje · 2023-11-17T22:21:34Z

Hooking this into Bazel is going to be non-trivial, I've already submitted ruby/rbs#1624 and soutaro/steep#962, but there is a lot of work still to do. This shouldn't stop us from merging the PR though!

titusfortner · 2023-11-17T22:29:44Z

How does this get used with bazel? Isn't this just type hints to show up in IDE or are we looking for bazel to be able to enforce typing?

p0deje · 2023-11-17T22:57:23Z

@titusfortner I suppose we'd like to run typecheck on CI too to make sure we don't introduce invalid RBS sgnatures.

aguspe · 2023-11-18T15:38:08Z

Here is the full patch that makes this work on MRI and JRuby:

diff --git a/rb/Gemfile b/rb/Gemfile
index 9710e18d99..7b58c4e54f 100644
--- a/rb/Gemfile
+++ b/rb/Gemfile
@@ -6,3 +6,5 @@ Dir["#{__dir__}/*.gemspec"].each do |spec|
 end
 
 gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw]
+gem 'rbs', '~> 3.2', require: false, platforms: %i[mri mingw x64_mingw]
+gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw]
diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock
index 5c72bfe7f7..bd8604143b 100644
--- a/rb/Gemfile.lock
+++ b/rb/Gemfile.lock
@@ -11,7 +11,8 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.1)
+    abbrev (0.1.1)
+    activesupport (7.1.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -24,41 +25,44 @@ GEM
     addressable (2.8.4)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
-    base64 (0.1.1)
+    base64 (0.2.0)
     bigdecimal (3.1.4)
-    bigdecimal (3.1.4-java)
     concurrent-ruby (1.2.2)
     connection_pool (2.4.1)
     crack (0.4.5)
       rexml
-    csv (3.2.7)
+    csv (3.2.8)
     debug (1.8.0)
       irb (>= 1.5.0)
       reline (>= 0.3.1)
     diff-lcs (1.5.0)
-    drb (2.1.1)
+    drb (2.2.0)
       ruby2_keywords
     ffi (1.16.3)
-    fileutils (1.7.1)
+    ffi (1.16.3-x64-mingw32)
+    fileutils (1.7.2)
     hashdiff (1.0.1)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     io-console (0.6.0)
-    irb (1.7.0)
-      reline (>= 0.3.0)
+    irb (1.9.0)
+      rdoc
+      reline (>= 0.3.8)
     json (2.6.3)
     json (2.6.3-java)
     language_server-protocol (3.17.0.3)
     listen (3.8.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.5.3)
+    logger (1.6.0)
     minitest (5.20.0)
-    mutex_m (0.1.2)
+    mutex_m (0.2.0)
     parallel (1.23.0)
     parser (3.2.2.3)
       ast (~> 2.4.1)
       racc
+    psych (5.1.1.1)
+      stringio
     public_suffix (5.0.1)
     racc (1.7.1)
     racc (1.7.1-java)
@@ -68,9 +72,12 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rbs (3.2.2)
+    rbs (3.3.0)
+      abbrev
+    rdoc (6.6.0)
+      psych (>= 4.0.0)
     regexp_parser (2.8.1)
-    reline (0.3.5)
+    reline (0.4.0)
       io-console (~> 0.5)
     rexml (3.2.5)
     rspec (3.12.0)
@@ -113,7 +120,7 @@ GEM
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
-    securerandom (0.2.2)
+    securerandom (0.3.0)
     steep (1.5.3)
       activesupport (>= 5.1)
       concurrent-ruby (>= 1.1.10)
@@ -129,8 +136,8 @@ GEM
       securerandom (>= 0.1)
       strscan (>= 1.0.0)
       terminal-table (>= 2, < 4)
+    stringio (3.0.9)
     strscan (3.0.7)
-    strscan (3.0.7-java)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     tzinfo (2.0.6)
@@ -147,6 +154,8 @@ GEM
 PLATFORMS
   java
   ruby
+  universal-java-1.8
+  universal-java-17
   universal-java-18
   x64-mingw32
 
@@ -154,14 +163,14 @@ DEPENDENCIES
   debug (~> 1.7)
   rack (~> 2.0)
   rake (~> 13.0)
-  rbs (~> 3.2.0)
+  rbs (~> 3.2)
   rspec (~> 3.0)
   rubocop (~> 1.42)
   rubocop-performance (~> 1.15)
   rubocop-rspec (~> 2.16)
   selenium-devtools!
   selenium-webdriver!
-  steep (~> 1.5)
+  steep (~> 1.5.0)
   webmock (~> 3.5)
   webrick (~> 1.7)
   yard (~> 0.9.11)
diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec
index 42254af43d..35349a72a9 100644
--- a/rb/selenium-webdriver.gemspec
+++ b/rb/selenium-webdriver.gemspec
@@ -62,12 +62,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'webmock', ['~> 3.5']
   s.add_development_dependency 'webrick', ['~> 1.7']
   s.add_development_dependency 'yard', ['~> 0.9.11']
-
-  if RUBY_PLATFORM == 'java'
-    s.add_development_dependency 'rbs', ['1.2.0']
-    s.add_development_dependency 'steep', ['0.46.0']
-  else
-    s.add_development_dependency 'rbs', ['~> 3.2.0']
-    s.add_development_dependency 'steep', ['~> 1.5']
-  end
 end

@aguspe I can merge your PR and commit this on top if you believe it's mergeable.

I think it is, thank you @p0deje for looking into this, this is better than having a conditional on the gemspec

p0deje · 2023-11-18T22:52:19Z

@aguspe would you like to commit this or do you want me to?

aguspe · 2023-11-18T23:59:49Z

@aguspe would you like to commit this or do you want me to?

I added the suggested changes on the last commit, the only difference is that I added Steep from 1.6.0 and remove the need for RBS.

Steep depends on RBS, so when we install Steep we already have access to RBS on the commandline, so there is no need to install it again

p0deje · 2023-11-19T01:23:23Z

@aguspe would you like to commit this or do you want me to?

I added the suggested changes on the last commit, the only difference is that I added Steep from 1.6.0 and remove the need for RBS.

I had to use Steep 1.5 due to soutaro/steep#962

aguspe · 2023-11-19T10:05:50Z

soutaro/steep#962

Makes sense, reverted to 1.5.0

aguspe · 2023-11-20T19:51:39Z

@titusfortner After this is merged, I will make a second PR to keep expanding RBS support

p0deje · 2023-11-20T22:52:23Z

@aguspe Thank you for the contribution!

aguspe marked this pull request as draft September 30, 2023 13:13

aguspe marked this pull request as ready for review October 22, 2023 16:14

titusfortner requested a review from p0deje October 22, 2023 18:44

p0deje reviewed Oct 23, 2023

View reviewed changes

aguspe force-pushed the add_rbs_files_to_ruby branch from 5a65b70 to 81a1670 Compare October 29, 2023 18:20

p0deje approved these changes Nov 1, 2023

View reviewed changes

Pexpe added 12 commits November 4, 2023 18:15

Started generating RBS files and modifying types

0c98d81

Improve types in driver added RBS files for Element, Navigation and T…

360e144

…argetLocator

Expand support for driver and starting adding manager, timeouts, vers…

5029445

…ion and window

Updated driver and window, and starting working on action builder, ke…

c5eabb8

…y actions, pointer actions, scroll origin

Update driver add input_device, navigation and pointer actions

c9e35f2

Update driver added remote, remote-response, devtools-response, virtu…

ce82619

…al_authenticator

Updated atoms, bridge, chrome, chromium and features

ea5f748

Expanded the features RBS for chrome and chromium, and added has_cast…

9b57c31

…ing and has_launching.rbs

Last update for the first RBS support PR

a2e1128

Update Steepfile

d5d4d0b

Remove comments and static values

3af8488

Resolve conflicts

3acc6b2

Pexpe and others added 2 commits November 6, 2023 20:58

Revert 4.2.0 and add exact version support for Jruby

6c31948

Merge branch 'trunk' into add_rbs_files_to_ruby

d920a7b

aguspe and others added 3 commits November 17, 2023 21:08

Merge branch 'trunk' into add_rbs_files_to_ruby

100bc50

Exclude Steep for Jruby, update Gemfile.lock

e54c555

Exclude Steep for Jruby, update Gemfile.lock

1eea737

Apply the changes suggested by p0deje, added steep 1.6.0 and removed rbs

9c24d25

Reverting to steep 1.5.0

f3cde2c

p0deje merged commit b9ef666 into SeleniumHQ:trunk Nov 20, 2023
24 of 30 checks passed

aguspe mentioned this pull request Nov 23, 2023

[rb] Extend RBS support for logger and log entry #13192

Merged

8 tasks

aguspe mentioned this pull request Dec 2, 2023

[rb] Add all the RBS files to add full rbs support to all selenium rb classes and modules #13234

Merged

8 tasks

aguspe mentioned this pull request Mar 19, 2024

[rb] Expand RBS typing support by replacing untypes with precise typing #13709

Draft

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RBS files to Ruby #12844

Add RBS files to Ruby #12844

aguspe commented Sep 30, 2023 •

edited

CLAassistant commented Sep 30, 2023 •

edited

titusfortner commented Oct 8, 2023

codecov-commenter commented Oct 8, 2023

aguspe commented Oct 16, 2023 •

edited

titusfortner commented Oct 16, 2023 •

edited

aguspe commented Oct 16, 2023

titusfortner commented Oct 16, 2023

aguspe commented Oct 17, 2023

titusfortner commented Oct 17, 2023

aguspe commented Oct 22, 2023

p0deje left a comment

aguspe commented Oct 27, 2023

aguspe commented Oct 29, 2023

p0deje left a comment

titusfortner commented Nov 6, 2023

p0deje commented Nov 6, 2023

titusfortner commented Nov 6, 2023

titusfortner commented Nov 6, 2023 •

edited

aguspe commented Nov 16, 2023

titusfortner commented Nov 17, 2023

aguspe commented Nov 17, 2023

p0deje commented Nov 17, 2023

p0deje commented Nov 17, 2023

p0deje commented Nov 17, 2023

titusfortner commented Nov 17, 2023

p0deje commented Nov 17, 2023

aguspe commented Nov 18, 2023

p0deje commented Nov 18, 2023

aguspe commented Nov 18, 2023

p0deje commented Nov 19, 2023

aguspe commented Nov 19, 2023

aguspe commented Nov 20, 2023

p0deje commented Nov 20, 2023

Add RBS files to Ruby #12844

Add RBS files to Ruby #12844

Conversation

aguspe commented Sep 30, 2023 • edited

Description

Motivation and Context

Types of changes

Checklist

CLAassistant commented Sep 30, 2023 • edited

titusfortner commented Oct 8, 2023

codecov-commenter commented Oct 8, 2023

Codecov Report

aguspe commented Oct 16, 2023 • edited

titusfortner commented Oct 16, 2023 • edited

aguspe commented Oct 16, 2023

titusfortner commented Oct 16, 2023

aguspe commented Oct 17, 2023

titusfortner commented Oct 17, 2023

aguspe commented Oct 22, 2023

p0deje left a comment

Choose a reason for hiding this comment

aguspe commented Oct 27, 2023

aguspe commented Oct 29, 2023

p0deje left a comment

Choose a reason for hiding this comment

titusfortner commented Nov 6, 2023

p0deje commented Nov 6, 2023

titusfortner commented Nov 6, 2023

titusfortner commented Nov 6, 2023 • edited

aguspe commented Nov 16, 2023

titusfortner commented Nov 17, 2023

aguspe commented Nov 17, 2023

p0deje commented Nov 17, 2023

p0deje commented Nov 17, 2023

p0deje commented Nov 17, 2023

titusfortner commented Nov 17, 2023

p0deje commented Nov 17, 2023

aguspe commented Nov 18, 2023

p0deje commented Nov 18, 2023

aguspe commented Nov 18, 2023

p0deje commented Nov 19, 2023

aguspe commented Nov 19, 2023

aguspe commented Nov 20, 2023

p0deje commented Nov 20, 2023

aguspe commented Sep 30, 2023 •

edited

CLAassistant commented Sep 30, 2023 •

edited

aguspe commented Oct 16, 2023 •

edited

titusfortner commented Oct 16, 2023 •

edited

titusfortner commented Nov 6, 2023 •

edited